Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h" 5 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 profile->GetPath().Append(chrome::kOfflinePageRequestQueueDirname); 75 profile->GetPath().Append(chrome::kOfflinePageRequestQueueDirname);
76 76
77 std::unique_ptr<RequestQueueStoreSQL> queue_store( 77 std::unique_ptr<RequestQueueStoreSQL> queue_store(
78 new RequestQueueStoreSQL(background_task_runner, queue_store_path)); 78 new RequestQueueStoreSQL(background_task_runner, queue_store_path));
79 std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(queue_store))); 79 std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(queue_store)));
80 std::unique_ptr<Scheduler> 80 std::unique_ptr<Scheduler>
81 scheduler(new android::BackgroundSchedulerBridge()); 81 scheduler(new android::BackgroundSchedulerBridge());
82 net::NetworkQualityEstimator::NetworkQualityProvider* 82 net::NetworkQualityEstimator::NetworkQualityProvider*
83 network_quality_estimator = 83 network_quality_estimator =
84 UINetworkQualityEstimatorServiceFactory::GetForProfile(profile); 84 UINetworkQualityEstimatorServiceFactory::GetForProfile(profile);
85 // TODO(fgorski): Something needs to keep the handle to the Notification
86 // dispatcher.
87 RequestCoordinator* request_coordinator = new RequestCoordinator( 85 RequestCoordinator* request_coordinator = new RequestCoordinator(
88 std::move(policy), std::move(offliner), std::move(queue), 86 std::move(policy), std::move(offliner), std::move(queue),
89 std::move(scheduler), network_quality_estimator); 87 std::move(scheduler), network_quality_estimator);
90 88
91 DownloadNotifyingObserver::CreateAndStartObserving( 89 DownloadNotifyingObserver::CreateAndStartObserving(
92 request_coordinator, 90 request_coordinator,
93 base::MakeUnique<android::OfflinePageNotificationBridge>()); 91 base::MakeUnique<android::OfflinePageNotificationBridge>());
94 92
95 return request_coordinator; 93 return request_coordinator;
96 } 94 }
97 95
98 } // namespace offline_pages 96 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698