Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Side by Side Diff: components/offline_pages/core/background/request_queue_unittest.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/background/request_queue.h" 5 #include "components/offline_pages/core/background/request_queue.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 } 78 }
79 79
80 int32_t total_expired_requests() { return total_expired_requests_; } 80 int32_t total_expired_requests() { return total_expired_requests_; }
81 81
82 private: 82 private:
83 BackgroundSavePageResult last_request_expiration_status_; 83 BackgroundSavePageResult last_request_expiration_status_;
84 SavePageRequest last_expired_request_; 84 SavePageRequest last_expired_request_;
85 int32_t total_expired_requests_; 85 int32_t total_expired_requests_;
86 }; 86 };
87 87
88 // TODO(fgorski): Add tests for store failures in add/remove/get.
89 class RequestQueueTest : public testing::Test { 88 class RequestQueueTest : public testing::Test {
90 public: 89 public:
91 RequestQueueTest(); 90 RequestQueueTest();
92 ~RequestQueueTest() override; 91 ~RequestQueueTest() override;
93 92
94 // Test overrides. 93 // Test overrides.
95 void SetUp() override; 94 void SetUp() override;
96 95
97 void PumpLoop(); 96 void PumpLoop();
98 97
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 // Doing a get should show no entries left in the queue since the expired 573 // Doing a get should show no entries left in the queue since the expired
575 // request has been removed. 574 // request has been removed.
576 queue()->GetRequests( 575 queue()->GetRequests(
577 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 576 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
578 this->PumpLoop(); 577 this->PumpLoop();
579 ASSERT_EQ(GetRequestsResult::SUCCESS, this->last_get_requests_result()); 578 ASSERT_EQ(GetRequestsResult::SUCCESS, this->last_get_requests_result());
580 ASSERT_TRUE(this->last_requests().empty()); 579 ASSERT_TRUE(this->last_requests().empty());
581 } 580 }
582 581
583 } // namespace offline_pages 582 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698