Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: components/offline_pages/core/offline_page_test_store.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/offline_page_test_store.cc
diff --git a/components/offline_pages/core/offline_page_test_store.cc b/components/offline_pages/core/offline_page_test_store.cc
index 556c12a2356e5ae0e1ea7acdb0a6786a7029cf56..225d777694d55ea042e7ee5d2e9ee1236749c248 100644
--- a/components/offline_pages/core/offline_page_test_store.cc
+++ b/components/offline_pages/core/offline_page_test_store.cc
@@ -44,7 +44,6 @@ void OfflinePageTestStore::GetOfflinePages(const LoadCallback& callback) {
void OfflinePageTestStore::AddOfflinePage(const OfflinePageItem& offline_page,
const AddCallback& callback) {
- // TODO(fgorski): Add and cover scenario with existing item.
ItemActionStatus result;
if (store_state_ == StoreState::LOADED &&
scenario_ != TestScenario::WRITE_FAILED) {
@@ -61,8 +60,6 @@ void OfflinePageTestStore::AddOfflinePage(const OfflinePageItem& offline_page,
void OfflinePageTestStore::UpdateOfflinePages(
const std::vector<OfflinePageItem>& pages,
const UpdateCallback& callback) {
- // TODO(fgorski): Cover scenario where new items are being created while they
- // shouldn't.
std::unique_ptr<OfflinePagesUpdateResult> result(
new OfflinePagesUpdateResult(StoreState::LOADED));
if (scenario_ == TestScenario::WRITE_FAILED) {
« no previous file with comments | « components/offline_pages/core/offline_page_test_archiver.h ('k') | components/offline_pages/core/offline_store_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698