components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc - Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/core/offline_page_archiver.h ('k') | components/offline_pages/core/offline_page_metadata_store_sql.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc

diff --git a/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc b/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc

index 36abbcc98f9b9182c435d68fd6bb3fa9891bebc3..56edf8e0303d41e0e7c68b491ad833f5ff782e49 100644

--- a/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc

+++ b/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc

@@ -392,8 +392,6 @@ void OfflinePageMetadataStoreTest::GetOfflinePagesCallback(

void OfflinePageMetadataStoreTest::AddCallback(ItemActionStatus status) {

last_called_callback_ = ADD;

- // TODO(fgorski): Add specific add status.

- // last_item_status_ = status;

last_status_ =

status == ItemActionStatus::SUCCESS ? STATUS_TRUE : STATUS_FALSE;

}