[wasm] Make Opcode names consistent across architectures, implementations

[wasm] Make Opcode names consistent across architectures, implementations
- Fix opcode names to be consistent with opcodes as in wasm-opcodes.h
- Fix Ordering of Ops, inconsistencies 

BUG=v8:6020
Review-Url: https://codereview.chromium.org/2776753004
Cr-Commit-Position: refs/heads/master@{#44239}
Committed: https://chromium.googlesource.com/v8/v8/+/6234fda3c9dcf223a243172d03ea1588f9cfe28d

[gdeepti, 2017-03-25 00:01:17]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 00:01:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 00:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 00:03:45]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23282)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19771)

[gdeepti, 2017-03-25 00:08:11]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 00:08:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 00:10:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 00:10:24]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23283)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19772)

[gdeepti, 2017-03-25 00:17:15]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 00:17:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 00:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 00:47:10]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-03-27 07:23:49]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 07:24:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 07:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 07:26:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/23330)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19792)

[gdeepti, 2017-03-27 07:32:41]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 07:32:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 07:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 07:34:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23304)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/23221)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19793)

[gdeepti, 2017-03-27 07:53:39]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 07:53:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-03-27 07:55:11]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 07:55:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 08:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:19:11]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-03-27 18:20:22]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 18:20:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 18:46:46]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-03-27 19:23:21]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:23:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:26:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:26:15]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19854)

[gdeepti, 2017-03-27 19:41:44]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:41:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:46:40]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[gdeepti, 2017-03-27 19:59:22]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:59:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 20:22:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 20:22:34]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-03-27 22:33:13]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:33:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:35:50]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23376)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/19868)

[gdeepti, 2017-03-27 22:38:20]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:38:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-03-27 22:41:58]

Description was changed from

==========
[wasm] Make Opcode names consistent across architectures, implementations

BUG=v8:6020
==========

to

==========
[wasm] Make Opcode names consistent across architectures, implementations
- Fix opcode names to be consistent with opcodes as in wasm-opcodes.h
- Fix Ordering of Ops, inconsistencies 

BUG=v8:6020
==========

[gdeepti, 2017-03-27 22:41:58]

gdeepti@chromium.org changed reviewers:
+ aseemgarg@chromium.org, bbudge@chromium.org, mtrofin@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:02:00]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-03-27 23:02:30]

I will be taking a second look to make sure the ordering is consistent, sending
out for pre-review as the CL has quite a bit of churn.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/machine-o...
File src/compiler/machine-operator.h (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/machine-o...
src/compiler/machine-operator.h:541: const Operator* Simd128Store3();
Can these be removed? Or are we still considering these as future SIMD ops?

[bbudge, 2017-03-28 00:13:26]

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/code-...
File src/compiler/arm/code-generator-arm.cc (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/code-...
src/compiler/arm/code-generator-arm.cc:1645: case kArmF32x4SConvertI32x4: {
these are unary ops, so should remain above.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/code-...
src/compiler/arm/code-generator-arm.cc:1696: case kArmI32x4Shl: {
Shifts are unary and should be moved back.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/instr...
File src/compiler/arm/instruction-codes-arm.h (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/instr...
src/compiler/arm/instruction-codes-arm.h:222: V(ArmSimd128Select)              \
Simd -> S

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/machine-o...
File src/compiler/machine-operator.h (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/machine-o...
src/compiler/machine-operator.h:541: const Operator* Simd128Store3();
On 2017/03/27 23:02:30, gdeepti wrote:
> Can these be removed? Or are we still considering these as future SIMD ops? 

Go ahead and remove them.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/opcodes.h
File src/compiler/opcodes.h (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/opcodes.h...
src/compiler/opcodes.h:672: V(Simd128Load3)               \
Remove the partial loads/stores

[gdeepti, 2017-03-28 19:49:24]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 19:49:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 19:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:51:59]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/23451)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[gdeepti, 2017-03-28 20:06:29]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 20:06:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:19:56]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-03-28 21:54:14]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 21:54:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:59:54]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[gdeepti, 2017-03-28 22:04:42]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:04:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-03-28 22:06:40]

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/code-...
File src/compiler/arm/code-generator-arm.cc (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/code-...
src/compiler/arm/code-generator-arm.cc:1645: case kArmF32x4SConvertI32x4: {
On 2017/03/28 00:13:26, bbudge wrote:
> these are unary ops, so should remain above.

Done.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/code-...
src/compiler/arm/code-generator-arm.cc:1696: case kArmI32x4Shl: {
On 2017/03/28 00:13:26, bbudge wrote:
> Shifts are unary and should be moved back.

Done.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/instr...
File src/compiler/arm/instruction-codes-arm.h (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/arm/instr...
src/compiler/arm/instruction-codes-arm.h:222: V(ArmSimd128Select)              \
On 2017/03/28 00:13:26, bbudge wrote:
> Simd -> S

Done.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/machine-o...
File src/compiler/machine-operator.h (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/machine-o...
src/compiler/machine-operator.h:541: const Operator* Simd128Store3();
On 2017/03/28 00:13:26, bbudge wrote:
> On 2017/03/27 23:02:30, gdeepti wrote:
> > Can these be removed? Or are we still considering these as future SIMD ops? 
> 
> Go ahead and remove them.

Done.

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/opcodes.h
File src/compiler/opcodes.h (right):

https://codereview.chromium.org/2776753004/diff/220001/src/compiler/opcodes.h...
src/compiler/opcodes.h:672: V(Simd128Load3)               \
On 2017/03/28 00:13:26, bbudge wrote:
> Remove the partial loads/stores

Done.

[aseemgarg, 2017-03-28 22:25:22]

https://codereview.chromium.org/2776753004/diff/280001/src/compiler/arm/code-...
File src/compiler/arm/code-generator-arm.cc (left):

https://codereview.chromium.org/2776753004/diff/280001/src/compiler/arm/code-...
src/compiler/arm/code-generator-arm.cc:1573: case kArmFloat32x4FromInt32x4: {
seems like you forgot to create the convert cases for these two.

[gdeepti, 2017-03-28 22:27:24]

https://codereview.chromium.org/2776753004/diff/280001/src/compiler/arm/code-...
File src/compiler/arm/code-generator-arm.cc (left):

https://codereview.chromium.org/2776753004/diff/280001/src/compiler/arm/code-...
src/compiler/arm/code-generator-arm.cc:1573: case kArmFloat32x4FromInt32x4: {
On 2017/03/28 22:25:22, aseemgarg wrote:
> seems like you forgot to create the convert cases for these two.

Fixed in the patch I uploaded right after this one.

[commit-bot: I haz the power, 2017-03-28 22:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:28:00]

Dry run: This issue passed the CQ dry run.

[aseemgarg, 2017-03-28 22:28:29]

lgtm

[bbudge, 2017-03-29 00:33:20]

lgtm

https://codereview.chromium.org/2776753004/diff/300001/src/compiler/arm/instr...
File src/compiler/arm/instruction-scheduler-arm.cc (right):

https://codereview.chromium.org/2776753004/diff/300001/src/compiler/arm/instr...
src/compiler/arm/instruction-scheduler-arm.cc:136: case kArmI32x4UConvertF32x4:
nit: out of order

[gdeepti, 2017-03-29 00:53:03]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 00:53:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 00:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 00:55:26]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-03-29 00:56:08]

Fixed inconsistency with Signed AddSaturate/SubSaturate to
AddSaturateS/SubSaturateS.

https://codereview.chromium.org/2776753004/diff/300001/src/compiler/arm/instr...
File src/compiler/arm/instruction-scheduler-arm.cc (right):

https://codereview.chromium.org/2776753004/diff/300001/src/compiler/arm/instr...
src/compiler/arm/instruction-scheduler-arm.cc:136: case kArmI32x4UConvertF32x4:
On 2017/03/29 00:33:19, bbudge wrote:
> nit: out of order

Done.

[gdeepti, 2017-03-29 00:59:26]

gdeepti@chromium.org changed reviewers:
+ bmeurer@chromium.org

[gdeepti, 2017-03-29 00:59:27]

+bmeurer@ for owners in src/compiler.

[gdeepti, 2017-03-29 01:00:17]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 01:00:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:26:29]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-03-29 04:07:24]

lgtm

[gdeepti, 2017-03-29 06:35:12]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2017-03-29 06:35:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
aseemgarg@chromium.org
Link to the patchset: https://codereview.chromium.org/2776753004/#ps320001
(title: "Fix Saturates")

[commit-bot: I haz the power, 2017-03-29 06:35:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 06:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 06:38:09]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37905)

[Mircea Trofin, 2017-03-29 16:59:35]

rubber stamp LGTM for wasm OWNERS part.

[gdeepti, 2017-03-29 17:00:36]

The CQ bit was checked by gdeepti@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:00:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:02:18]

CQ is committing da patch.

Bot data: {"patchset_id": 320001, "attempt_start_ts": 1490806836431680,
"parent_rev": "88f71126a5c067f98c75044bc26778f2e8ea2e79", "commit_rev":
"6234fda3c9dcf223a243172d03ea1588f9cfe28d"}

[commit-bot: I haz the power, 2017-03-29 17:02:27]

Description was changed from

==========
[wasm] Make Opcode names consistent across architectures, implementations
- Fix opcode names to be consistent with opcodes as in wasm-opcodes.h
- Fix Ordering of Ops, inconsistencies 

BUG=v8:6020
==========

to

==========
[wasm] Make Opcode names consistent across architectures, implementations
- Fix opcode names to be consistent with opcodes as in wasm-opcodes.h
- Fix Ordering of Ops, inconsistencies 

BUG=v8:6020

Review-Url: https://codereview.chromium.org/2776753004
Cr-Commit-Position: refs/heads/master@{#44239}
Committed:
https://chromium.googlesource.com/v8/v8/+/6234fda3c9dcf223a243172d03ea1588f9c...
==========

[commit-bot: I haz the power, 2017-03-29 17:02:28]

Committed patchset #17 (id:320001) as
https://chromium.googlesource.com/v8/v8/+/6234fda3c9dcf223a243172d03ea1588f9c...