[wasm] Make Opcode names consistent across architectures, implementations

src/compiler/machine-operator.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_MACHINE_OPERATOR_H_
 #define V8_COMPILER_MACHINE_OPERATOR_H_
 
 #include "src/base/compiler-specific.h"
 #include "src/base/flags.h"
 #include "src/globals.h"
@@ skipping 412 matching lines @@
   const Operator* Float64ExtractLowWord32();
   const Operator* Float64ExtractHighWord32();
   const Operator* Float64InsertLowWord32();
   const Operator* Float64InsertHighWord32();
 
   // Change signalling NaN to quiet NaN.
   // Identity for any input that is not signalling NaN.
   const Operator* Float64SilenceNaN();
 
   // SIMD operators.
-  const Operator* Float32x4Splat();
-  const Operator* Float32x4ExtractLane(int32_t);
-  const Operator* Float32x4ReplaceLane(int32_t);
-  const Operator* Float32x4Abs();
-  const Operator* Float32x4Neg();
-  const Operator* Float32x4Sqrt();
-  const Operator* Float32x4RecipApprox();
-  const Operator* Float32x4RecipSqrtApprox();
-  const Operator* Float32x4Add();
-  const Operator* Float32x4Sub();
-  const Operator* Float32x4Mul();
-  const Operator* Float32x4Div();
-  const Operator* Float32x4Min();
-  const Operator* Float32x4Max();
-  const Operator* Float32x4MinNum();
-  const Operator* Float32x4MaxNum();
-  const Operator* Float32x4RecipRefine();
-  const Operator* Float32x4RecipSqrtRefine();
-  const Operator* Float32x4Equal();
-  const Operator* Float32x4NotEqual();
-  const Operator* Float32x4LessThan();
-  const Operator* Float32x4LessThanOrEqual();
-  const Operator* Float32x4FromInt32x4();
-  const Operator* Float32x4FromUint32x4();
+  const Operator* F32x4Splat();
+  const Operator* F32x4ExtractLane(int32_t);
+  const Operator* F32x4ReplaceLane(int32_t);
+  const Operator* F32x4Abs();
+  const Operator* F32x4Neg();
+  const Operator* F32x4Sqrt();
+  const Operator* F32x4RecipApprox();
+  const Operator* F32x4RecipSqrtApprox();
+  const Operator* F32x4Add();
+  const Operator* F32x4Sub();
+  const Operator* F32x4Mul();
+  const Operator* F32x4Div();
+  const Operator* F32x4Min();
+  const Operator* F32x4Max();
+  const Operator* F32x4MinNum();
+  const Operator* F32x4MaxNum();
+  const Operator* F32x4RecipRefine();
+  const Operator* F32x4RecipSqrtRefine();
+  const Operator* F32x4Eq();
+  const Operator* F32x4Ne();
+  const Operator* F32x4Lt();
+  const Operator* F32x4Le();
+  const Operator* F32x4SConvertI32x4();
+  const Operator* F32x4UConvertI32x4();
 
-  const Operator* Int32x4Splat();
-  const Operator* Int32x4ExtractLane(int32_t);
-  const Operator* Int32x4ReplaceLane(int32_t);
-  const Operator* Int32x4Neg();
-  const Operator* Int32x4Add();
-  const Operator* Int32x4Sub();
-  const Operator* Int32x4Mul();
-  const Operator* Int32x4Min();
-  const Operator* Int32x4Max();
-  const Operator* Int32x4ShiftLeftByScalar(int32_t);
-  const Operator* Int32x4ShiftRightByScalar(int32_t);
-  const Operator* Int32x4Equal();
-  const Operator* Int32x4NotEqual();
-  const Operator* Int32x4LessThan();
-  const Operator* Int32x4LessThanOrEqual();
-  const Operator* Int32x4FromFloat32x4();
+  const Operator* I32x4Splat();
+  const Operator* I32x4ExtractLane(int32_t);
+  const Operator* I32x4ReplaceLane(int32_t);
+  const Operator* I32x4Neg();
+  const Operator* I32x4Add();
+  const Operator* I32x4Sub();
+  const Operator* I32x4Mul();
+  const Operator* I32x4MinS();
+  const Operator* I32x4MaxS();
+  const Operator* I32x4Shl(int32_t);
+  const Operator* I32x4ShrS(int32_t);
+  const Operator* I32x4Eq();
+  const Operator* I32x4Ne();
+  const Operator* I32x4LtS();
+  const Operator* I32x4LeS();
+  const Operator* I32x4SConvertF32x4();
 
-  const Operator* Uint32x4Min();
-  const Operator* Uint32x4Max();
-  const Operator* Uint32x4ShiftRightByScalar(int32_t);
-  const Operator* Uint32x4LessThan();
-  const Operator* Uint32x4LessThanOrEqual();
-  const Operator* Uint32x4FromFloat32x4();
+  const Operator* I32x4MinU();
+  const Operator* I32x4MaxU();
+  const Operator* I32x4ShrU(int32_t);
+  const Operator* I32x4LtU();
+  const Operator* I32x4LeU();
+  const Operator* I32x4UConvertF32x4();
 
-  const Operator* Int16x8Splat();
-  const Operator* Int16x8ExtractLane(int32_t);
-  const Operator* Int16x8ReplaceLane(int32_t);
-  const Operator* Int16x8Neg();
-  const Operator* Int16x8Add();
-  const Operator* Int16x8AddSaturate();
-  const Operator* Int16x8Sub();
-  const Operator* Int16x8SubSaturate();
-  const Operator* Int16x8Mul();
-  const Operator* Int16x8Min();
-  const Operator* Int16x8Max();
-  const Operator* Int16x8ShiftLeftByScalar(int32_t);
-  const Operator* Int16x8ShiftRightByScalar(int32_t);
-  const Operator* Int16x8Equal();
-  const Operator* Int16x8NotEqual();
-  const Operator* Int16x8LessThan();
-  const Operator* Int16x8LessThanOrEqual();
+  const Operator* I16x8Splat();
+  const Operator* I16x8ExtractLane(int32_t);
+  const Operator* I16x8ReplaceLane(int32_t);
+  const Operator* I16x8Neg();
+  const Operator* I16x8Add();
+  const Operator* I16x8AddSaturate();
+  const Operator* I16x8Sub();
+  const Operator* I16x8SubSaturate();
+  const Operator* I16x8Mul();
+  const Operator* I16x8MinS();
+  const Operator* I16x8MaxS();
+  const Operator* I16x8Shl(int32_t);
+  const Operator* I16x8ShrS(int32_t);
+  const Operator* I16x8Eq();
+  const Operator* I16x8Ne();
+  const Operator* I16x8LtS();
+  const Operator* I16x8LeS();
 
-  const Operator* Uint16x8AddSaturate();
-  const Operator* Uint16x8SubSaturate();
-  const Operator* Uint16x8Min();
-  const Operator* Uint16x8Max();
-  const Operator* Uint16x8ShiftRightByScalar(int32_t);
-  const Operator* Uint16x8LessThan();
-  const Operator* Uint16x8LessThanOrEqual();
+  const Operator* I16x8AddSaturateU();
+  const Operator* I16x8SubSaturateU();
+  const Operator* I16x8MinU();
+  const Operator* I16x8MaxU();
+  const Operator* I16x8ShrU(int32_t);
+  const Operator* I16x8LtU();
+  const Operator* I16x8LeU();
 
-  const Operator* Int8x16Splat();
-  const Operator* Int8x16ExtractLane(int32_t);
-  const Operator* Int8x16ReplaceLane(int32_t);
-  const Operator* Int8x16Neg();
-  const Operator* Int8x16Add();
-  const Operator* Int8x16AddSaturate();
-  const Operator* Int8x16Sub();
-  const Operator* Int8x16SubSaturate();
-  const Operator* Int8x16Mul();
-  const Operator* Int8x16Min();
-  const Operator* Int8x16Max();
-  const Operator* Int8x16ShiftLeftByScalar(int32_t);
-  const Operator* Int8x16ShiftRightByScalar(int32_t);
-  const Operator* Int8x16Equal();
-  const Operator* Int8x16NotEqual();
-  const Operator* Int8x16LessThan();
-  const Operator* Int8x16LessThanOrEqual();
+  const Operator* I8x16Splat();
+  const Operator* I8x16ExtractLane(int32_t);
+  const Operator* I8x16ReplaceLane(int32_t);
+  const Operator* I8x16Neg();
+  const Operator* I8x16Add();
+  const Operator* I8x16AddSaturate();
+  const Operator* I8x16Sub();
+  const Operator* I8x16SubSaturate();
+  const Operator* I8x16Mul();
+  const Operator* I8x16MinS();
+  const Operator* I8x16MaxS();
+  const Operator* I8x16Shl(int32_t);
+  const Operator* I8x16ShrS(int32_t);
+  const Operator* I8x16Eq();
+  const Operator* I8x16Ne();
+  const Operator* I8x16LtS();
+  const Operator* I8x16LeS();
 
-  const Operator* Uint8x16AddSaturate();
-  const Operator* Uint8x16SubSaturate();
-  const Operator* Uint8x16Min();
-  const Operator* Uint8x16Max();
-  const Operator* Uint8x16ShiftRightByScalar(int32_t);
-  const Operator* Uint8x16LessThan();
-  const Operator* Uint8x16LessThanOrEqual();
+  const Operator* I8x16AddSaturateU();
+  const Operator* I8x16SubSaturateU();
+  const Operator* I8x16MinU();
+  const Operator* I8x16MaxU();
+  const Operator* I8x16ShrU(int32_t);
+  const Operator* I8x16LtU();
+  const Operator* I8x16LeU();
 
   const Operator* Simd128Load();
   const Operator* Simd128Load1();
   const Operator* Simd128Load2();
   const Operator* Simd128Load3();
   const Operator* Simd128Store();
   const Operator* Simd128Store1();
   const Operator* Simd128Store2();
   const Operator* Simd128Store3();

[gdeepti, 2017/03/27 23:02:30]

Can these be removed? Or are we still considering these as future SIMD ops? 

[bbudge, 2017/03/28 00:13:26]

Go ahead and remove them.

[gdeepti, 2017/03/28 22:06:40]

Done.

 
-  const Operator* Simd128Zero();
-  const Operator* Simd128And();
-  const Operator* Simd128Or();
-  const Operator* Simd128Xor();
-  const Operator* Simd128Not();
+  const Operator* S128Zero();
+  const Operator* S128And();
+  const Operator* S128Or();
+  const Operator* S128Xor();
+  const Operator* S128Not();
 
-  const Operator* Simd32x4Select();
-  const Operator* Simd32x4Swizzle(uint32_t);
-  const Operator* Simd32x4Shuffle();
-  const Operator* Simd16x8Select();
-  const Operator* Simd16x8Swizzle(uint32_t);
-  const Operator* Simd16x8Shuffle();
-  const Operator* Simd8x16Select();
-  const Operator* Simd8x16Swizzle(uint32_t);
-  const Operator* Simd8x16Shuffle();
+  const Operator* S32x4Select();
+  const Operator* S32x4Swizzle(uint32_t);
+  const Operator* S32x4Shuffle();
+  const Operator* S16x8Select();
+  const Operator* S16x8Swizzle(uint32_t);
+  const Operator* S16x8Shuffle();
+  const Operator* S8x16Select();
+  const Operator* S8x16Swizzle(uint32_t);
+  const Operator* S8x16Shuffle();
 
-  const Operator* Simd1x4Zero();
-  const Operator* Simd1x4And();
-  const Operator* Simd1x4Or();
-  const Operator* Simd1x4Xor();
-  const Operator* Simd1x4Not();
-  const Operator* Simd1x4AnyTrue();
-  const Operator* Simd1x4AllTrue();
+  const Operator* S1x4Zero();
+  const Operator* S1x4And();
+  const Operator* S1x4Or();
+  const Operator* S1x4Xor();
+  const Operator* S1x4Not();
+  const Operator* S1x4AnyTrue();
+  const Operator* S1x4AllTrue();
 
-  const Operator* Simd1x8Zero();
-  const Operator* Simd1x8And();
-  const Operator* Simd1x8Or();
-  const Operator* Simd1x8Xor();
-  const Operator* Simd1x8Not();
-  const Operator* Simd1x8AnyTrue();
-  const Operator* Simd1x8AllTrue();
+  const Operator* S1x8Zero();
+  const Operator* S1x8And();
+  const Operator* S1x8Or();
+  const Operator* S1x8Xor();
+  const Operator* S1x8Not();
+  const Operator* S1x8AnyTrue();
+  const Operator* S1x8AllTrue();
 
-  const Operator* Simd1x16Zero();
-  const Operator* Simd1x16And();
-  const Operator* Simd1x16Or();
-  const Operator* Simd1x16Xor();
-  const Operator* Simd1x16Not();
-  const Operator* Simd1x16AnyTrue();
-  const Operator* Simd1x16AllTrue();
+  const Operator* S1x16Zero();
+  const Operator* S1x16And();
+  const Operator* S1x16Or();
+  const Operator* S1x16Xor();
+  const Operator* S1x16Not();
+  const Operator* S1x16AnyTrue();
+  const Operator* S1x16AllTrue();
 
   // load [base + index]
   const Operator* Load(LoadRepresentation rep);
   const Operator* ProtectedLoad(LoadRepresentation rep);
 
   // store [base + index], value
   const Operator* Store(StoreRepresentation rep);
   const Operator* ProtectedStore(MachineRepresentation rep);
 
   // unaligned load [base + index]
@@ skipping 82 matching lines @@
 };
 
 
 DEFINE_OPERATORS_FOR_FLAGS(MachineOperatorBuilder::Flags)
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_MACHINE_OPERATOR_H_