DescriptionRevert of Reland "Add enable_ipc_logging build argument" (patchset #1 id:1 of https://codereview.chromium.org/2777983005/ )
Reason for revert:
This still appears to be causing a build flake on https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng
log: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_rel_ng%2F418400%2F%2B%2Frecipes%2Fsteps%2Fcompile__without_patch_%2F0%2Fstdout
Original issue's description:
> Reland "Add enable_ipc_logging build argument (patchset #2 id:20001 of https://codereview.chromium.org/2770653002/ )"
>
> It introduced a build flake due to assorted missing dependencies
> on //ipc and it was reverted in https://codereview.chromium.org/2768403002.
> The public dependencies on //ipc are fixed in https://codereview.chromium.org/2767193005.
>
> Original issue's description:
> > Add enable_ipc_logging build argument
> >
> > Implement a build option to enable the IPC logging system
> > in release builds. It's useful to save time and resources when
> > debugging IPC communication (e.g. in automated testing
> > environments).
> >
> > It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2770653002
> > Cr-Commit-Position: refs/heads/master@{#459094}
> > Committed: https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d4e61c30f8e08
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2777983005
> Cr-Commit-Position: refs/heads/master@{#460152}
> Committed: https://chromium.googlesource.com/chromium/src/+/b39d83360c64113ff17e64169c49e1a83329b61e
TBR=rockot@chromium.org,jam@chromium.org,kenrb@chromium.org,davidsz@inf.u-szeged.hu
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2776393003
Cr-Commit-Position: refs/heads/master@{#460218}
Committed: https://chromium.googlesource.com/chromium/src/+/c1028928eaec4fd84d29a81c462152f3e6fbf08c
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|