Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2768403002: Revert of Add enable_ipc_logging build argument (Closed)

Created:
3 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add enable_ipc_logging build argument (patchset #2 id:20001 of https://codereview.chromium.org/2770653002/ ) Reason for revert: Causing build flake due to assorted missing dependencies on //ipc. Will reland after https://codereview.chromium.org/2767193005 lands. Original issue's description: > Add enable_ipc_logging build argument > > Implement a build option to enable the IPC logging system > in release builds. It's useful to save time and resources when > debugging IPC communication (e.g. in automated testing > environments). > > It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag. > > BUG= > > Review-Url: https://codereview.chromium.org/2770653002 > Cr-Commit-Position: refs/heads/master@{#459094} > Committed: https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d4e61c30f8e08 TBR=cpu@chromium.org,jam@chromium.org,kenrb@chromium.org,davidsz@inf.u-szeged.hu # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2768403002 Cr-Commit-Position: refs/heads/master@{#459198} Committed: https://chromium.googlesource.com/chromium/src/+/844b401fbaf5ced17e83fba254ca26fab258a86e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -68 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/logging_chrome.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_ipc_logging.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/child_process_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/child_process_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/content_ipc_logging.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/public/browser/browser_ipc_logging.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_ipc_logging.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/BUILD.gn View 2 chunks +0 lines, -13 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_logging.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_logging.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message.h View 3 chunks +6 lines, -3 lines 0 comments Download
M ipc/ipc_message.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/irt_ppapi.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of Add enable_ipc_logging build argument
3 years, 9 months ago (2017-03-23 20:17:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768403002/1
3 years, 9 months ago (2017-03-23 20:18:32 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 20:22:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/844b401fbaf5ced17e83fba254ca...

Powered by Google App Engine
This is Rietveld 408576698