ipc/ipc_logging.h - Issue 2776393003: Revert of Reland "Add enable_ipc_logging build argument"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_logging.h

Issue 2776393003: Revert of Reland "Add enable_ipc_logging build argument" (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_logging.h

diff --git a/ipc/ipc_logging.h b/ipc/ipc_logging.h

index 929f55e50a9c8e1a3f5c01c4e2fd59089a8eb136..af490f0c91e7fce1a2f94aab626252fa29e59d81 100644

--- a/ipc/ipc_logging.h

+++ b/ipc/ipc_logging.h

@@ -5,11 +5,12 @@

#ifndef IPC_IPC_LOGGING_H_

#define IPC_IPC_LOGGING_H_

-#include "ipc/ipc_features.h"

+#include <stdint.h>

-#if BUILDFLAG(IPC_MESSAGE_LOG_ENABLED)

+#include "ipc/ipc_message.h" // For IPC_MESSAGE_LOG_ENABLED.

-#include <stdint.h>

+#ifdef IPC_MESSAGE_LOG_ENABLED

#include <vector>

#include "base/containers/hash_tables.h"

@@ -17,7 +18,6 @@

#include "base/memory/singleton.h"

#include "base/single_thread_task_runner.h"

#include "ipc/ipc_export.h"

-#include "ipc/ipc_message.h"

// Logging function. |name| is a string in ASCII and |params| is a string in

// UTF-8.

@@ -123,6 +123,6 @@

} // namespace IPC

-#endif // BUILDFLAG(IPC_MESSAGE_LOG_ENABLED)

+#endif // IPC_MESSAGE_LOG_ENABLED

#endif // IPC_IPC_LOGGING_H_

« no previous file with comments | « ipc/ipc_channel_reader.cc ('k') | ipc/ipc_logging.cc » ('j') | no next file with comments »