Add enable_ipc_logging build argument

Add enable_ipc_logging build argument

Implement a build option to enable the IPC logging system
in release builds. It's useful to save time and resources when
debugging IPC communication (e.g. in automated testing
environments).

It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.

BUG=

Review-Url: https://codereview.chromium.org/2770653002
Cr-Commit-Position: refs/heads/master@{#459094}
Committed: https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d4e61c30f8e08

[Szabolcs David, 2017-03-22 14:53:11]

Description was changed from

==========
Add enable_ipc_logging build argument

Implement a build option to enable the IPC logging system
in release builds. It's useful to save time and resources when
debugging IPC communication (e.g. in automated testing
environments).

It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.

BUG=
==========

to

==========
Add enable_ipc_logging build argument

Implement a build option to enable the IPC logging system
in release builds. It's useful to save time and resources when
debugging IPC communication (e.g. in automated testing
environments).

It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.

BUG=
==========

[Szabolcs David, 2017-03-22 14:53:12]

davidsz@inf.u-szeged.hu changed reviewers:
+ cpu@chromium.org, jam@chromium.org, kenrb@chromium.org, rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-03-22 15:39:31]

Seems reasonable to me. I can always get behind more BUILDFLAG usage. LGTM and
thanks!

[jam, 2017-03-22 15:55:18]

lgtm

[Szabolcs David, 2017-03-22 16:07:24]

The CQ bit was checked by davidsz@inf.u-szeged.hu

[commit-bot: I haz the power, 2017-03-22 16:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 16:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 16:14:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kenrb, 2017-03-22 16:54:35]

lgtm for IPC security review

[Szabolcs David, 2017-03-23 09:45:20]

The CQ bit was checked by davidsz@inf.u-szeged.hu to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 09:45:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 10:40:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 10:40:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Szabolcs David, 2017-03-23 11:53:44]

The CQ bit was checked by davidsz@inf.u-szeged.hu

[Szabolcs David, 2017-03-23 11:53:44]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
rockot@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2770653002/#ps20001
(title: "Fix build of content_shell")

[commit-bot: I haz the power, 2017-03-23 11:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 13:48:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 13:48:17]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Szabolcs David, 2017-03-23 13:50:55]

The CQ bit was checked by davidsz@inf.u-szeged.hu

[commit-bot: I haz the power, 2017-03-23 13:51:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 15:45:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490277055425780,
"parent_rev": "762b38b0d18bf44ad5f0381583f45c2598ab470d", "commit_rev":
"76890ec11e7402591d1c9add533d4e61c30f8e08"}

[commit-bot: I haz the power, 2017-03-23 15:51:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490277055425780,
"parent_rev": "762b38b0d18bf44ad5f0381583f45c2598ab470d", "commit_rev":
"76890ec11e7402591d1c9add533d4e61c30f8e08"}

[commit-bot: I haz the power, 2017-03-23 15:51:28]

Description was changed from

==========
Add enable_ipc_logging build argument

Implement a build option to enable the IPC logging system
in release builds. It's useful to save time and resources when
debugging IPC communication (e.g. in automated testing
environments).

It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.

BUG=
==========

to

==========
Add enable_ipc_logging build argument

Implement a build option to enable the IPC logging system
in release builds. It's useful to save time and resources when
debugging IPC communication (e.g. in automated testing
environments).

It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag.

BUG=

Review-Url: https://codereview.chromium.org/2770653002
Cr-Commit-Position: refs/heads/master@{#459094}
Committed:
https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d...
==========

[commit-bot: I haz the power, 2017-03-23 15:51:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d...

[Szabolcs David, 2017-03-23 15:54:20]

Thank you guys for supporting my first patch in Chromium. :)

[findit-for-me, 2017-03-23 16:30:49]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2769823003/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit identified CL at revision 459094 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[stgao, 2017-03-23 17:43:21]

On 2017/03/23 16:30:49, findit-for-me wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2769823003/ by
> mailto:findit-for-me@appspot.gserviceaccount.com.
> 
> The reason for reverting is: 
> Findit identified CL at revision 459094 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

This is a false positive because due to flaky compile -- missing
ipc/ipc_features.h
Will investigate and file a bug for it.

[stgao, 2017-03-23 18:55:55]

On 2017/03/23 17:43:21, stgao(ping after 24h) wrote:
> On 2017/03/23 16:30:49, findit-for-me wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/2769823003/ by
> > mailto:findit-for-me@appspot.gserviceaccount.com.
> > 
> > The reason for reverting is: 
> > Findit identified CL at revision 459094 as the culprit for
> > failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....
> 
> This is a false positive because due to flaky compile -- missing
> ipc/ipc_features.h
> Will investigate and file a bug for it.

Update: It turned out that this CL is truely the culprit according to
https://codereview.chromium.org/2769823003/#msg8

[Ken Rockot(use gerrit already), 2017-03-23 20:15:42]

Alas, you also get to experience your first revert :)

We can reland this after https://codereview.chromium.org/2767193005 is landed,
as it fixes many missing public_deps on //ipc. Without those dependencies being
correct, this CL causes build flake.

[Ken Rockot(use gerrit already), 2017-03-23 20:17:30]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2768403002/ by rockot@chromium.org.

The reason for reverting is: Causing build flake due to assorted missing
dependencies on //ipc. Will reland after
https://codereview.chromium.org/2767193005 lands..