Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2777983005: Reland "Add enable_ipc_logging build argument" (Closed)

Created:
3 years, 8 months ago by Szabolcs David
Modified:
3 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Add enable_ipc_logging build argument (patchset #2 id:20001 of https://codereview.chromium.org/2770653002/ )" It introduced a build flake due to assorted missing dependencies on //ipc and it was reverted in https://codereview.chromium.org/2768403002. The public dependencies on //ipc are fixed in https://codereview.chromium.org/2767193005. Original issue's description: > Add enable_ipc_logging build argument > > Implement a build option to enable the IPC logging system > in release builds. It's useful to save time and resources when > debugging IPC communication (e.g. in automated testing > environments). > > It also turns IPC_MESSAGE_LOG_ENABLED macro to a build flag. > > BUG= > > Review-Url: https://codereview.chromium.org/2770653002 > Cr-Commit-Position: refs/heads/master@{#459094} > Committed: https://chromium.googlesource.com/chromium/src/+/76890ec11e7402591d1c9add533d4e61c30f8e08 BUG= Review-Url: https://codereview.chromium.org/2777983005 Cr-Commit-Position: refs/heads/master@{#460152} Committed: https://chromium.googlesource.com/chromium/src/+/b39d83360c64113ff17e64169c49e1a83329b61e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -64 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_ipc_logging.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/child_process_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/child_process_messages.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/content_ipc_logging.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/public/browser/browser_ipc_logging.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_ipc_logging.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_logging.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_logging.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message.h View 3 chunks +3 lines, -6 lines 0 comments Download
M ipc/ipc_message.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/irt_ppapi.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Szabolcs David
Can we try it again? :)
3 years, 8 months ago (2017-03-28 11:58:05 UTC) #7
Szabolcs David
3 years, 8 months ago (2017-03-28 11:58:25 UTC) #8
jam
rs lgtm
3 years, 8 months ago (2017-03-28 15:36:42 UTC) #9
kenrb
lgtm
3 years, 8 months ago (2017-03-28 15:39:07 UTC) #11
Ken Rockot(use gerrit already)
lgtm
3 years, 8 months ago (2017-03-28 15:40:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777983005/1
3 years, 8 months ago (2017-03-28 15:42:08 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b39d83360c64113ff17e64169c49e1a83329b61e
3 years, 8 months ago (2017-03-28 17:25:15 UTC) #19
jwd
3 years, 8 months ago (2017-03-28 21:10:03 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2776393003/ by jwd@chromium.org.

The reason for reverting is: This still appears to be causing a build flake on
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

log:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux....

Powered by Google App Engine
This is Rietveld 408576698