Fix public dependencies on //ipc

Fix public dependencies on //ipc

Several //ipc headers will soon depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2767193005
Cr-Commit-Position: refs/heads/master@{#459459}
Committed: https://chromium.googlesource.com/chromium/src/+/38e46ddf25c67b6d18667f3bc2b7a24aca8f22a4

[Ken Rockot(use gerrit already), 2017-03-23 18:21:16]

Description was changed from

==========
Fix public dependencies on //ipc

Several //ipc headers now depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
==========

to

==========
Fix public dependencies on //ipc

Several //ipc headers now depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Rockot(use gerrit already), 2017-03-23 18:21:18]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-03-23 18:21:31]

rockot@chromium.org changed reviewers:
+ jam@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:41:32]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-24 14:24:04]

Description was changed from

==========
Fix public dependencies on //ipc

Several //ipc headers now depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix public dependencies on //ipc

Several //ipc headers now depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jam, 2017-03-24 14:24:04]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[jam, 2017-03-24 14:24:04]

Description was changed from

==========
Fix public dependencies on //ipc

Several //ipc headers now depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix public dependencies on //ipc

Several //ipc headers now depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jam, 2017-03-24 14:24:05]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[jam, 2017-03-24 14:24:18]

I'm overloaded right now, Brett can you please take a look? Thanks

[brettw, 2017-03-24 16:35:56]

lgtm

[Ken Rockot(use gerrit already), 2017-03-24 16:36:49]

Description was changed from

==========
Fix public dependencies on //ipc

Several //ipc headers now depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix public dependencies on //ipc

Several //ipc headers will soon depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Rockot(use gerrit already), 2017-03-24 16:36:51]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-03-24 16:37:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 16:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 16:45:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2017-03-24 16:47:13]

Description was changed from

==========
Fix public dependencies on //ipc

Several //ipc headers will soon depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix public dependencies on //ipc

Several //ipc headers will soon depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dcheng@chromium.org
==========

[Ken Rockot(use gerrit already), 2017-03-24 16:47:43]

+TBR dcheng@ for gpu/ipc/common since it's just a deps change

[Ken Rockot(use gerrit already), 2017-03-24 16:47:53]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-03-24 16:48:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 16:55:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490374073167470, "parent_rev":
"30073908057a3870b4996992898035bec07391e3", "commit_rev":
"38e46ddf25c67b6d18667f3bc2b7a24aca8f22a4"}

[commit-bot: I haz the power, 2017-03-24 16:56:14]

Description was changed from

==========
Fix public dependencies on //ipc

Several //ipc headers will soon depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dcheng@chromium.org
==========

to

==========
Fix public dependencies on //ipc

Several //ipc headers will soon depend on a generated buildflag header, so
public dependents can cause compile flake by incorrectly specifying
their deps as private. This fixes a bunch of targets wrt to public //ipc
dependency.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2767193005
Cr-Commit-Position: refs/heads/master@{#459459}
Committed:
https://chromium.googlesource.com/chromium/src/+/38e46ddf25c67b6d18667f3bc2b7...
==========

[commit-bot: I haz the power, 2017-03-24 16:56:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38e46ddf25c67b6d18667f3bc2b7...