Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2776333005: Remove redundant WebLocalFrame* parameter from didChangeIcon (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from didChangeIcon Remove redundant WebLocalFrame* parameter from didChangeIcon in WebFrameClient. BUG=361765 Review-Url: https://codereview.chromium.org/2776333005 Cr-Commit-Position: refs/heads/master@{#461028} Committed: https://chromium.googlesource.com/chromium/src/+/88c790307bbc22ed6170541e3b1afdf524cf91f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/shell/test_runner/web_frame_test_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/test_runner/web_frame_test_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/test_runner/web_frame_test_proxy.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
sashab
3 years, 8 months ago (2017-03-29 06:21:19 UTC) #2
dglazkov
lgtm
3 years, 8 months ago (2017-03-29 15:00:09 UTC) #4
slangley
lgtm
3 years, 8 months ago (2017-03-29 23:19:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776333005/1
3 years, 8 months ago (2017-03-30 01:40:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398294)
3 years, 8 months ago (2017-03-30 01:52:50 UTC) #9
sashab
jochen ptal @ content
3 years, 8 months ago (2017-03-30 02:02:08 UTC) #11
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-30 11:46:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776333005/1
3 years, 8 months ago (2017-03-31 00:30:00 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 04:31:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88c790307bbc22ed6170541e3b1a...

Powered by Google App Engine
This is Rietveld 408576698