Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: content/shell/test_runner/web_frame_test_proxy.h

Issue 2776333005: Remove redundant WebLocalFrame* parameter from didChangeIcon (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_ 5 #ifndef CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_
6 #define CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_ 6 #define CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 Base::didCommitProvisionalLoad(frame, item, commit_type); 128 Base::didCommitProvisionalLoad(frame, item, commit_type);
129 } 129 }
130 130
131 void didReceiveTitle(blink::WebLocalFrame* frame, 131 void didReceiveTitle(blink::WebLocalFrame* frame,
132 const blink::WebString& title, 132 const blink::WebString& title,
133 blink::WebTextDirection direction) override { 133 blink::WebTextDirection direction) override {
134 test_client()->didReceiveTitle(frame, title, direction); 134 test_client()->didReceiveTitle(frame, title, direction);
135 Base::didReceiveTitle(frame, title, direction); 135 Base::didReceiveTitle(frame, title, direction);
136 } 136 }
137 137
138 void didChangeIcon(blink::WebLocalFrame* frame, 138 void didChangeIcon(blink::WebIconURL::Type icon_type) override {
139 blink::WebIconURL::Type icon_type) override { 139 test_client()->didChangeIcon(icon_type);
140 test_client()->didChangeIcon(frame, icon_type); 140 Base::didChangeIcon(icon_type);
141 Base::didChangeIcon(frame, icon_type);
142 } 141 }
143 142
144 void didFinishDocumentLoad(blink::WebLocalFrame* frame) override { 143 void didFinishDocumentLoad(blink::WebLocalFrame* frame) override {
145 test_client()->didFinishDocumentLoad(frame); 144 test_client()->didFinishDocumentLoad(frame);
146 Base::didFinishDocumentLoad(frame); 145 Base::didFinishDocumentLoad(frame);
147 } 146 }
148 147
149 void didHandleOnloadEvents(blink::WebLocalFrame* frame) override { 148 void didHandleOnloadEvents(blink::WebLocalFrame* frame) override {
150 test_client()->didHandleOnloadEvents(frame); 149 test_client()->didHandleOnloadEvents(frame);
151 Base::didHandleOnloadEvents(frame); 150 Base::didHandleOnloadEvents(frame);
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 return test_client()->runFileChooser(params, completion); 297 return test_client()->runFileChooser(params, completion);
299 } 298 }
300 299
301 private: 300 private:
302 DISALLOW_COPY_AND_ASSIGN(WebFrameTestProxy); 301 DISALLOW_COPY_AND_ASSIGN(WebFrameTestProxy);
303 }; 302 };
304 303
305 } // namespace test_runner 304 } // namespace test_runner
306 305
307 #endif // CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_ 306 #endif // CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_
OLDNEW
« no previous file with comments | « content/shell/test_runner/web_frame_test_client.cc ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698