Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

Issue 2776333005: Remove redundant WebLocalFrame* parameter from didChangeIcon (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 437
438 void LocalFrameClientImpl::dispatchDidReceiveTitle(const String& title) { 438 void LocalFrameClientImpl::dispatchDidReceiveTitle(const String& title) {
439 if (m_webFrame->client()) { 439 if (m_webFrame->client()) {
440 m_webFrame->client()->didReceiveTitle(m_webFrame, title, 440 m_webFrame->client()->didReceiveTitle(m_webFrame, title,
441 WebTextDirectionLeftToRight); 441 WebTextDirectionLeftToRight);
442 } 442 }
443 } 443 }
444 444
445 void LocalFrameClientImpl::dispatchDidChangeIcons(IconType type) { 445 void LocalFrameClientImpl::dispatchDidChangeIcons(IconType type) {
446 if (m_webFrame->client()) { 446 if (m_webFrame->client()) {
447 m_webFrame->client()->didChangeIcon(m_webFrame, 447 m_webFrame->client()->didChangeIcon(static_cast<WebIconURL::Type>(type));
448 static_cast<WebIconURL::Type>(type));
449 } 448 }
450 } 449 }
451 450
452 void LocalFrameClientImpl::dispatchDidCommitLoad(HistoryItem* item, 451 void LocalFrameClientImpl::dispatchDidCommitLoad(HistoryItem* item,
453 HistoryCommitType commitType) { 452 HistoryCommitType commitType) {
454 if (!m_webFrame->parent()) { 453 if (!m_webFrame->parent()) {
455 m_webFrame->viewImpl()->didCommitLoad(commitType == StandardCommit, false); 454 m_webFrame->viewImpl()->didCommitLoad(commitType == StandardCommit, false);
456 } 455 }
457 456
458 if (m_webFrame->client()) { 457 if (m_webFrame->client()) {
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 if (m_webFrame->client()) 1032 if (m_webFrame->client())
1034 m_webFrame->client()->setHasReceivedUserGesture(); 1033 m_webFrame->client()->setHasReceivedUserGesture();
1035 } 1034 }
1036 1035
1037 void LocalFrameClientImpl::abortClientNavigation() { 1036 void LocalFrameClientImpl::abortClientNavigation() {
1038 if (m_webFrame->client()) 1037 if (m_webFrame->client())
1039 m_webFrame->client()->abortClientNavigation(); 1038 m_webFrame->client()->abortClientNavigation();
1040 } 1039 }
1041 1040
1042 } // namespace blink 1041 } // namespace blink
OLDNEW
« no previous file with comments | « content/shell/test_runner/web_frame_test_proxy.h ('k') | third_party/WebKit/public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698