Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2776333005: Remove redundant WebLocalFrame* parameter from didChangeIcon (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/LocalFrameClientImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 // Like |didCreateDocumentElement|, except this method may run JavaScript 383 // Like |didCreateDocumentElement|, except this method may run JavaScript
384 // code (and possibly invalidate the frame). 384 // code (and possibly invalidate the frame).
385 virtual void runScriptsAtDocumentElementAvailable(WebLocalFrame*) {} 385 virtual void runScriptsAtDocumentElementAvailable(WebLocalFrame*) {}
386 386
387 // The page title is available. 387 // The page title is available.
388 virtual void didReceiveTitle(WebLocalFrame* frame, 388 virtual void didReceiveTitle(WebLocalFrame* frame,
389 const WebString& title, 389 const WebString& title,
390 WebTextDirection direction) {} 390 WebTextDirection direction) {}
391 391
392 // The icon for the page have changed. 392 // The icon for the page have changed.
393 virtual void didChangeIcon(WebLocalFrame*, WebIconURL::Type) {} 393 virtual void didChangeIcon(WebIconURL::Type) {}
394 394
395 // The frame's document finished loading. 395 // The frame's document finished loading.
396 // This method may not execute JavaScript code. 396 // This method may not execute JavaScript code.
397 virtual void didFinishDocumentLoad(WebLocalFrame*) {} 397 virtual void didFinishDocumentLoad(WebLocalFrame*) {}
398 398
399 // Like |didFinishDocumentLoad|, except this method may run JavaScript 399 // Like |didFinishDocumentLoad|, except this method may run JavaScript
400 // code (and possibly invalidate the frame). 400 // code (and possibly invalidate the frame).
401 virtual void runScriptsAtDocumentReady(WebLocalFrame*, bool documentIsEmpty) { 401 virtual void runScriptsAtDocumentReady(WebLocalFrame*, bool documentIsEmpty) {
402 } 402 }
403 403
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 // Overwrites the given URL to use an HTML5 embed if possible. 759 // Overwrites the given URL to use an HTML5 embed if possible.
760 // An empty URL is returned if the URL is not overriden. 760 // An empty URL is returned if the URL is not overriden.
761 virtual WebURL overrideFlashEmbedWithHTML(const WebURL& url) { 761 virtual WebURL overrideFlashEmbedWithHTML(const WebURL& url) {
762 return WebURL(); 762 return WebURL();
763 } 763 }
764 }; 764 };
765 765
766 } // namespace blink 766 } // namespace blink
767 767
768 #endif 768 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/LocalFrameClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698