content/shell/test_runner/web_frame_test_client.h - Issue 2776333005: Remove redundant WebLocalFrame* parameter from didChangeIcon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/web_frame_test_client.h

Issue 2776333005: Remove redundant WebLocalFrame* parameter from didChangeIcon (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/web_frame_test_client.h

diff --git a/content/shell/test_runner/web_frame_test_client.h b/content/shell/test_runner/web_frame_test_client.h

index fe92fe1072b903cef95ff11a2c789a9c7cf7100d..4041065b3f4228e40d0068ffe55942cd5730e6b4 100644

--- a/content/shell/test_runner/web_frame_test_client.h

+++ b/content/shell/test_runner/web_frame_test_client.h

@@ -75,8 +75,7 @@ class WebFrameTestClient : public blink::WebFrameClient {

void didReceiveTitle(blink::WebLocalFrame* frame,

const blink::WebString& title,

blink::WebTextDirection direction) override;

- void didChangeIcon(blink::WebLocalFrame* frame,

- blink::WebIconURL::Type icon_type) override;

+ void didChangeIcon(blink::WebIconURL::Type icon_type) override;

void didFinishDocumentLoad(blink::WebLocalFrame* frame) override;

void didHandleOnloadEvents(blink::WebLocalFrame* frame) override;

void didFailLoad(blink::WebLocalFrame* frame,