Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate checkbox label to a proper web component This also allows to use <label for='..'> and removes manual click events. BUG=none Review-Url: https://codereview.chromium.org/2776263006 Cr-Commit-Position: refs/heads/master@{#460599} Committed: https://chromium.googlesource.com/chromium/src/+/27533094be842d574cfe813bdcf8f8ec1094f4b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -111 lines) Patch
M third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 3 chunks +87 lines, -88 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dgozman
Please take a look.
3 years, 8 months ago (2017-03-29 22:42:28 UTC) #2
lushnikov
lgtm
3 years, 8 months ago (2017-03-29 22:47:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776263006/1
3 years, 8 months ago (2017-03-29 23:00:22 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 00:39:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27533094be842d574cfe813bdcf8...

Powered by Google App Engine
This is Rietveld 408576698