third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js - Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js b/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

index a079438d23c4956d0eca1b9d7010e857502b09ed..8613deca5f52f392c6529fb223993d88717dfe82 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

@@ -68,7 +68,7 @@ Main.RenderingOptionsView = class extends UI.VBox {

this.contentElement.createChild('div').classList.add('panel-section-separator');

var cssMediaSubtitle = Common.UIString('Forces media type for testing print and screen styles');

- var checkboxLabel = UI.createCheckboxLabel(Common.UIString('Emulate CSS Media'), false, cssMediaSubtitle);

+ var checkboxLabel = UI.CheckboxLabel.create(Common.UIString('Emulate CSS Media'), false, cssMediaSubtitle);

this._mediaCheckbox = checkboxLabel.checkboxElement;

this._mediaCheckbox.addEventListener('click', this._mediaToggled.bind(this), false);

this.contentElement.appendChild(checkboxLabel);

@@ -98,7 +98,7 @@ Main.RenderingOptionsView = class extends UI.VBox {

* @param {string=} subtitle

_appendCheckbox(label, setterName, subtitle) {

- var checkboxLabel = UI.createCheckboxLabel(label, false, subtitle);

+ var checkboxLabel = UI.CheckboxLabel.create(label, false, subtitle);

this._settings.set(setterName, checkboxLabel.checkboxElement);

checkboxLabel.checkboxElement.addEventListener('click', this._settingToggled.bind(this, setterName));

this.contentElement.appendChild(checkboxLabel);