third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js - Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js b/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

index 1a3bfca051808503608f5465cd8a7075ea0cf473..1d19ce2425cf1d4158acfc8c002a56a2ebef52c4 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

@@ -125,7 +125,7 @@ UI.SearchableView = class extends UI.VBox {

// Build the replace checkbox and cancel button.

this._replaceElement = this._footerElement.createChild('div').createChild('span', 'toolbar-replace-checkbox');

- var replaceLabelElement = UI.createCheckboxLabel(Common.UIString('Replace'));

+ var replaceLabelElement = UI.CheckboxLabel.create(Common.UIString('Replace'));

this._replaceCheckboxElement = replaceLabelElement.checkboxElement;

var uniqueId = ++UI.SearchableView._lastUniqueId;

var replaceCheckboxId = 'search-replace-trigger' + uniqueId;