Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
index f573242e2c3469e68b069fda8c160fc4a57cf49e..6f1a58c99724fb1959db45cc0fa24735abd2f416 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
@@ -209,13 +209,12 @@ Audits.AuditLauncherView = class extends UI.VBox {
* @param {string=} id
*/
_createCategoryElement(title, id) {
- var labelElement = UI.createCheckboxLabel(title);
+ var labelElement = UI.CheckboxLabel.create(title);
if (id) {
labelElement.id = this._categoryIdPrefix + id;
labelElement.checkboxElement.addEventListener('click', this._boundCategoryClickListener, false);
}
- labelElement.__displayName = title;
-
+ /** @type {!Object} */ (labelElement).__displayName = title;
return labelElement;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698