Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
index d9b546c40f692a155053decf461aa896a4bd78f1..666a36e1fa67919496f3aed16d3ba24142fd4533 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
@@ -197,7 +197,7 @@ UI.TextFilterUI = class extends Common.Object {
if (this._supportRegex) {
this._filterElement.classList.add('supports-regex');
- var label = UI.createCheckboxLabel(Common.UIString('Regex'));
+ var label = UI.CheckboxLabel.create(Common.UIString('Regex'));
this._regexCheckBox = label.checkboxElement;
this._regexCheckBox.id = 'text-filter-regex';
this._regexCheckBox.addEventListener('change', this._valueChanged.bind(this), false);
@@ -558,7 +558,7 @@ UI.CheckboxFilterUI = class extends Common.Object {
super();
this._filterElement = createElementWithClass('div', 'filter-checkbox-filter');
this._activeWhenChecked = !!activeWhenChecked;
- this._label = UI.createCheckboxLabel(title);
+ this._label = UI.CheckboxLabel.create(title);
this._filterElement.appendChild(this._label);
this._checkboxElement = this._label.checkboxElement;
if (setting)

Powered by Google App Engine
This is Rietveld 408576698