third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js - Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

diff --git a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

index fc3fdd70d7b297c26b2443a9995b3766db24af29..98471961f8663bb191dddf95c1cf6fe35e749a5b 100644

--- a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

+++ b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

@@ -447,7 +447,7 @@ Settings.ExperimentsSettingsTab = class extends Settings.SettingsTab {

}

_createExperimentCheckbox(experiment) {

- var label = UI.createCheckboxLabel(Common.UIString(experiment.title), experiment.isEnabled());

+ var label = UI.CheckboxLabel.create(Common.UIString(experiment.title), experiment.isEnabled());

var input = label.checkboxElement;

input.name = experiment.name;

function listener() {