Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch

Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch

This CL hooks up the browser-side mojo endpoint with the rest of the
Background Fetch system to actually start a new background fetch.

BUG=692534
Review-Url: https://codereview.chromium.org/2774343002
Cr-Commit-Position: refs/heads/master@{#459905}
Committed: https://chromium.googlesource.com/chromium/src/+/8ea74ef3873df9a1b97277a1ddc92414137ff1cd

[harkness, 2017-03-27 15:35:11]

harkness@chromium.org changed reviewers:
+ harkness@chromium.org

[harkness, 2017-03-27 15:35:12]

lgtm % comments

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_data_manager.cc (right):

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_data_manager.cc:38: 
Can you put a TODO here for one of us to put the requests/options in the
BackgroundFetchRequestInfo/JobInfo/whatever?

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_data_manager.h (right):

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_data_manager.h:90: void
CreateRequestForTests(std::unique_ptr<BackgroundFetchJobInfo> job_info,
I don't see a definition of this? It looks like you just used WriteToStorage
instead?

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
File
content/browser/background_fetch/background_fetch_job_controller_unittest.cc
(right):

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_job_controller_unittest.cc:166:
did_complete_job_ = true;
optional: DCHECK that registration_id is equal to the id passed into
InitializeJobController?

[Peter Beverloo, 2017-03-27 15:42:54]

peter@chromium.org changed reviewers:
+ avi@chromium.org, isherman@chromium.org, tsepez@chromium.org

[Peter Beverloo, 2017-03-27 15:42:56]

+harkness, please take another look at BackgroundFetchServiceImpl
+tsepez for mojom and first BackgroundFetchServiceImpl method
+avi for bad_messages.h and RPHI OWNERS
+isherman for UMA

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_data_manager.cc (right):

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_data_manager.cc:38: 
On 2017/03/27 15:35:12, harkness wrote:
> Can you put a TODO here for one of us to put the requests/options in the
> BackgroundFetchRequestInfo/JobInfo/whatever?

Done.

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_data_manager.h (right):

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_data_manager.h:90: void
CreateRequestForTests(std::unique_ptr<BackgroundFetchJobInfo> job_info,
On 2017/03/27 15:35:12, harkness wrote:
> I don't see a definition of this? It looks like you just used WriteToStorage
> instead?

Oops, removed.

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
File
content/browser/background_fetch/background_fetch_job_controller_unittest.cc
(right):

https://codereview.chromium.org/2774343002/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_job_controller_unittest.cc:166:
did_complete_job_ = true;
On 2017/03/27 15:35:12, harkness wrote:
> optional: DCHECK that registration_id is equal to the id passed into
> InitializeJobController?

Done.

[Peter Beverloo, 2017-03-27 18:37:17]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 18:38:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-03-27 18:39:04]

lgtm

[Avi (use Gerrit), 2017-03-27 18:40:34]

lgtm

content stuff stamp

[Ilya Sherman, 2017-03-27 18:53:15]

histograms.xml lgtm

[commit-bot: I haz the power, 2017-03-27 21:39:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 21:39:40]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-03-27 21:54:59]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-03-27 21:55:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
harkness@chromium.org
Link to the patchset: https://codereview.chromium.org/2774343002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-27 21:55:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:21:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490651699602040,
"parent_rev": "635e74d4f8a9afddae305b83da36cb3dcba8f1c1", "commit_rev":
"8ea74ef3873df9a1b97277a1ddc92414137ff1cd"}

[commit-bot: I haz the power, 2017-03-27 22:21:47]

Description was changed from

==========
Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch

This CL hooks up the browser-side mojo endpoint with the rest of the
Background Fetch system to actually start a new background fetch.

BUG=692534
==========

to

==========
Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch

This CL hooks up the browser-side mojo endpoint with the rest of the
Background Fetch system to actually start a new background fetch.

BUG=692534

Review-Url: https://codereview.chromium.org/2774343002
Cr-Commit-Position: refs/heads/master@{#459905}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ea74ef3873df9a1b97277a1ddc9...
==========

[commit-bot: I haz the power, 2017-03-27 22:21:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8ea74ef3873df9a1b97277a1ddc9...