Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch

content/browser/background_fetch/background_fetch_data_manager.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_DATA_MANAGER_H_
 #define CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_DATA_MANAGER_H_
 
 #include <memory>
 #include <set>
 #include <string>
 #include <unordered_map>
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "content/browser/background_fetch/background_fetch_job_info.h"
 #include "content/browser/background_fetch/background_fetch_job_response_data.h"
+#include "content/browser/background_fetch/background_fetch_registration_id.h"
 #include "content/browser/background_fetch/background_fetch_request_info.h"
-#include "content/browser/background_fetch/background_fetch_registration_id.h"
 #include "content/common/content_export.h"
+#include "third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom.h"
 #include "url/origin.h"
 
 namespace content {
 
 class BrowserContext;
 class BlobHandle;
 
 // The BackgroundFetchDataManager keeps track of all of the outstanding requests
 // which are in process in the DownloadManager. When Chromium restarts, it is
 // responsibile for reconnecting all the in progress downloads with an observer
 // which will keep the metadata up to date.
 class CONTENT_EXPORT BackgroundFetchDataManager {
  public:
+  using CreateRegistrationCallback =
+      base::OnceCallback<void(blink::mojom::BackgroundFetchError)>;
+  using DeleteRegistrationCallback =
+      base::OnceCallback<void(blink::mojom::BackgroundFetchError)>;
+
   explicit BackgroundFetchDataManager(BrowserContext* browser_context);
   ~BackgroundFetchDataManager();
 
-  // Called by BackgroundFetchContext when a new request is started, this will
-  // store all of the necessary metadata to track the request.
-  void CreateRequest(std::unique_ptr<BackgroundFetchJobInfo> job_info,
-                     BackgroundFetchRequestInfos request_infos);
+  // Creates and stores a new registration with the given properties. Will
+  // invoke the |callback| when the registration has been created, which may
+  // fail due to invalid input or storage errors.
+  void CreateRegistration(
+      const BackgroundFetchRegistrationId& registration_id,
+      const std::vector<ServiceWorkerFetchRequest>& requests,
+      const BackgroundFetchOptions& options,
+      CreateRegistrationCallback callback);
+
+  // Deletes the registration identified by |registration_id|. Will invoke the
+  // |callback| when the registration has been deleted from storage.
+  void DeleteRegistration(const BackgroundFetchRegistrationId& registration_id,
+                          DeleteRegistrationCallback callback);
 
   // TODO(harkness): Replace the OnceClosure with a callback to return the
   // response object once it is decided whether lifetime should be passed to the
   // caller or stay here.
   void GetJobResponse(const std::string& job_guid,
                       const BackgroundFetchResponseCompleteCallback& callback);
 
   // The following methods are called by the JobController to update job state.
   // Returns a boolean indicating whether there are more requests to process.
   virtual bool UpdateRequestState(const std::string& job_guid,
@@ skipping 13 matching lines @@
   virtual const BackgroundFetchRequestInfo& GetNextBackgroundFetchRequestInfo(
       const std::string& job_guid);
 
   // Indicates whether all requests have been handed to the JobController.
   virtual bool HasRequestsRemaining(const std::string& job_guid) const;
 
   // Indicates whether all requests have been handed out and completed.
   virtual bool IsComplete(const std::string& job_guid) const;
 
  private:
+  friend class BackgroundFetchDataManagerTest;
+
+  void CreateRequestForTests(std::unique_ptr<BackgroundFetchJobInfo> job_info,

[harkness, 2017/03/27 15:35:12]

I don't see a definition of this? It looks like you just used WriteToStorage
instead?

[Peter Beverloo, 2017/03/27 15:42:55]

Oops, removed.

+                             BackgroundFetchRequestInfos request_infos);
+
   // Storage interface.
   void WriteJobToStorage(std::unique_ptr<BackgroundFetchJobInfo> job_info,
                          BackgroundFetchRequestInfos request_infos);
   void WriteRequestToStorage(const std::string& job_guid,
                              BackgroundFetchRequestInfo* request_info);
   std::unique_ptr<BackgroundFetchRequestInfo> GetRequestInfo(
       const std::string& job_guid,
       size_t request_index);
 
   void DidGetRequestResponse(const std::string& job_guid,
                              int request_sequence_number,
                              std::unique_ptr<BlobHandle> blob_handle);
 
   // Indirectly, this is owned by the BrowserContext.
   BrowserContext* browser_context_;
 
   // Set of known background fetch registration ids.
-  std::set<BackgroundFetchRegistrationId> known_registrations_;
+  std::set<BackgroundFetchRegistrationId> registrations_;
 
   // Map from job_guid to JobInfo.
   std::unordered_map<std::string, std::unique_ptr<BackgroundFetchJobInfo>>
       job_map_;
 
   // Temporary map to hold data which will be written to storage.
   // Map from job_guid to RequestInfos.
   std::unordered_map<std::string, std::vector<BackgroundFetchRequestInfo>>
       request_map_;
 
   base::WeakPtrFactory<BackgroundFetchDataManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BackgroundFetchDataManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_DATA_MANAGER_H_