Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/browser/background_fetch/background_fetch_job_controller.h

Issue 2774343002: Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_job_controller.h
diff --git a/content/browser/background_fetch/background_fetch_job_controller.h b/content/browser/background_fetch/background_fetch_job_controller.h
index 1e7b982e1e5b8548239244211ced2cefd788cccb..ba641829f22245bc85e4e5aed18625e906f956e9 100644
--- a/content/browser/background_fetch/background_fetch_job_controller.h
+++ b/content/browser/background_fetch/background_fetch_job_controller.h
@@ -12,6 +12,7 @@
#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "content/browser/background_fetch/background_fetch_registration_id.h"
#include "content/common/content_export.h"
#include "content/public/browser/download_item.h"
@@ -28,11 +29,15 @@ class StoragePartition;
class CONTENT_EXPORT BackgroundFetchJobController
: public DownloadItem::Observer {
public:
- BackgroundFetchJobController(const std::string& job_guid,
- BrowserContext* browser_context,
- StoragePartition* storage_partition,
- BackgroundFetchDataManager* data_manager,
- base::OnceClosure completed_closure);
+ using CompletedCallback =
+ base::OnceCallback<void(const BackgroundFetchRegistrationId&)>;
+
+ BackgroundFetchJobController(
+ const BackgroundFetchRegistrationId& registration_id,
+ BrowserContext* browser_context,
+ StoragePartition* storage_partition,
+ BackgroundFetchDataManager* data_manager,
+ CompletedCallback completed_callback);
~BackgroundFetchJobController() override;
// Start processing on a batch of requests. Some of these may already be in
@@ -55,6 +60,10 @@ class CONTENT_EXPORT BackgroundFetchJobController
void ProcessRequest(const BackgroundFetchRequestInfo& request);
+ // The registration id on behalf of which this controller is fetching data.
+ BackgroundFetchRegistrationId registration_id_;
+
+ // TODO(peter): Deprecated, remove in favor of |registration_id|.
std::string job_guid_;
// Pointer to the browser context. The BackgroundFetchJobController is owned
@@ -72,7 +81,7 @@ class CONTENT_EXPORT BackgroundFetchJobController
BackgroundFetchDataManager* data_manager_;
// Callback for when all fetches have been completed.
- base::OnceClosure completed_closure_;
+ CompletedCallback completed_callback_;
// Map from the GUID assigned by the DownloadManager to the request_guid.
std::unordered_map<std::string, std::string> download_guid_map_;

Powered by Google App Engine
This is Rietveld 408576698