Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: content/browser/background_fetch/background_fetch_test_base.h

Issue 2774343002: Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/background_fetch/background_fetch_service_impl.cc ('k') | content/browser/bad_message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/background_fetch/background_fetch_test_base.h
diff --git a/content/browser/background_fetch/background_fetch_test_base.h b/content/browser/background_fetch/background_fetch_test_base.h
index 8f324745eeb128e54fe6005ef4001365016907e0..88cb48aaabbf1d6e542b5270b13b82b25989c0e0 100644
--- a/content/browser/background_fetch/background_fetch_test_base.h
+++ b/content/browser/background_fetch/background_fetch_test_base.h
@@ -32,9 +32,11 @@ class BackgroundFetchTestBase : public ::testing::Test {
void SetUp() override;
void TearDown() override;
- // Creates a valid Service Worker registration for the testing origin and
- // stores the data in the |*registration_id|. Returns whether creation was
- // successful, which must be asserted by tests.
+ // Creates a Background Fetch registration backed by a Service Worker
+ // registration for the testing origin. The resulting registration will be
+ // stored in |*registration_id|. Returns whether creation was successful,
+ // which must be asserted by tests. The ServiceWorkerRegistration that
+ // backs the |*registration_id| will be kept alive for the test's lifetime.
bool CreateRegistrationId(const std::string& tag,
BackgroundFetchRegistrationId* registration_id)
WARN_UNUSED_RESULT;
« no previous file with comments | « content/browser/background_fetch/background_fetch_service_impl.cc ('k') | content/browser/bad_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698