Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: content/browser/background_fetch/background_fetch_service_impl.h

Issue 2774343002: Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_service_impl.h
diff --git a/content/browser/background_fetch/background_fetch_service_impl.h b/content/browser/background_fetch/background_fetch_service_impl.h
index de6299b8c5cc9ee7dd51b3371bd464b4d033d181..9103eb92d946344f507f528c60d05270f9b7e962 100644
--- a/content/browser/background_fetch/background_fetch_service_impl.h
+++ b/content/browser/background_fetch/background_fetch_service_impl.h
@@ -9,6 +9,7 @@
#include <utility>
#include <vector>
+#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom.h"
@@ -21,18 +22,17 @@ namespace content {
class BackgroundFetchContext;
struct BackgroundFetchOptions;
-class ServiceWorkerContextWrapper;
class BackgroundFetchServiceImpl : public blink::mojom::BackgroundFetchService {
public:
BackgroundFetchServiceImpl(
- scoped_refptr<BackgroundFetchContext> background_fetch_context,
- scoped_refptr<ServiceWorkerContextWrapper> service_worker_context);
+ int render_process_id,
+ scoped_refptr<BackgroundFetchContext> background_fetch_context);
~BackgroundFetchServiceImpl() override;
static void Create(
+ int render_process_id,
scoped_refptr<BackgroundFetchContext> background_fetch_context,
- scoped_refptr<ServiceWorkerContextWrapper> service_worker_context,
blink::mojom::BackgroundFetchServiceRequest request);
// blink::mojom::BackgroundFetchService implementation.
@@ -59,8 +59,24 @@ class BackgroundFetchServiceImpl : public blink::mojom::BackgroundFetchService {
const GetTagsCallback& callback) override;
private:
+ // Validates and returns whether the |tag| contains a valid value. The
+ // renderer will be flagged for having send a bad message if it isn't.
+ bool ValidateTag(const std::string& tag) WARN_UNUSED_RESULT;
+
+ // Validates and returns whether |requests| contains at least a valid request.
+ // The renderer will be flagged for having send a bad message if it isn't.
+ bool ValidateRequests(const std::vector<ServiceWorkerFetchRequest>& requests)
+ WARN_UNUSED_RESULT;
+
+ // Validates and returns whether the |title| contains a valid value. The
+ // renderer will be flagged for having send a bad message if it isn't.
+ bool ValidateTitle(const std::string& title) WARN_UNUSED_RESULT;
+
+ // Id of the renderer process that this service has been created for.
+ int render_process_id_;
+
+ // The Background Fetch context on which operations will be dispatched.
scoped_refptr<BackgroundFetchContext> background_fetch_context_;
- scoped_refptr<ServiceWorkerContextWrapper> service_worker_context_;
DISALLOW_COPY_AND_ASSIGN(BackgroundFetchServiceImpl);
};

Powered by Google App Engine
This is Rietveld 408576698