Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch

content/browser/background_fetch/background_fetch_data_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/background_fetch/background_fetch_data_manager.h"
 
 #include "base/memory/ptr_util.h"
 #include "content/browser/background_fetch/background_fetch_context.h"
 #include "content/browser/background_fetch/background_fetch_job_response_data.h"
 #include "content/browser/background_fetch/background_fetch_request_info.h"
 #include "content/public/browser/blob_handle.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 #include "content/public/browser/download_item.h"
 
 namespace content {
 
 BackgroundFetchDataManager::BackgroundFetchDataManager(
     BrowserContext* browser_context)
     : browser_context_(browser_context), weak_ptr_factory_(this) {
   DCHECK(browser_context_);
   // TODO(harkness) Read from persistent storage and recreate requests.
 }
 
 BackgroundFetchDataManager::~BackgroundFetchDataManager() = default;
 
-void BackgroundFetchDataManager::CreateRequest(
-    std::unique_ptr<BackgroundFetchJobInfo> job_info,
-    BackgroundFetchRequestInfos request_infos) {
-  BackgroundFetchRegistrationId registration_id(
-      job_info->service_worker_registration_id(), job_info->origin(),
-      job_info->tag());
-
-  // Ensure that this is not a duplicate request.
-  if (known_registrations_.find(registration_id) !=
-      known_registrations_.end()) {
-    DVLOG(1) << "Origin " << job_info->origin()
-             << " has already created a batch request with tag "
-             << job_info->tag();
-    // TODO(harkness) Figure out how to return errors like this.
+void BackgroundFetchDataManager::CreateRegistration(
+    const BackgroundFetchRegistrationId& registration_id,
+    const std::vector<ServiceWorkerFetchRequest>& requests,
+    const BackgroundFetchOptions& options,
+    CreateRegistrationCallback callback) {
+  if (registrations_.find(registration_id) != registrations_.end()) {
+    std::move(callback).Run(blink::mojom::BackgroundFetchError::DUPLICATED_TAG);
     return;
   }
 
-  // Add the JobInfo to the in-memory map, and write the individual requests out
-  // to storage.
-  job_info->set_num_requests(request_infos.size());
-  const std::string job_guid = job_info->guid();
-  known_registrations_.insert(std::move(registration_id));
-  WriteJobToStorage(std::move(job_info), std::move(request_infos));
+  registrations_.insert(registration_id);
+

[harkness, 2017/03/27 15:35:12]

Can you put a TODO here for one of us to put the requests/options in the
BackgroundFetchRequestInfo/JobInfo/whatever?

[Peter Beverloo, 2017/03/27 15:42:55]

Done.

+  std::move(callback).Run(blink::mojom::BackgroundFetchError::NONE);
+}
+
+void BackgroundFetchDataManager::DeleteRegistration(
+    const BackgroundFetchRegistrationId& registration_id,
+    DeleteRegistrationCallback callback) {
+  auto iter = registrations_.find(registration_id);
+  if (iter == registrations_.end()) {
+    std::move(callback).Run(blink::mojom::BackgroundFetchError::INVALID_TAG);
+    return;
+  }
+
+  registrations_.erase(iter);
+
+  std::move(callback).Run(blink::mojom::BackgroundFetchError::NONE);
 }
 
 void BackgroundFetchDataManager::WriteJobToStorage(
     std::unique_ptr<BackgroundFetchJobInfo> job_info,
     BackgroundFetchRequestInfos request_infos) {
   // TODO(harkness): Check for job_guid clash.
   const std::string job_guid = job_info->guid();
   job_map_[job_guid] = std::move(job_info);
 
   // Make an explicit copy of the original requests
@@ skipping 158 matching lines @@
     const std::string& download_guid) {
   BackgroundFetchJobInfo* job_info = job_map_[job_guid].get();
   DCHECK(job_info);
   BackgroundFetchRequestInfo* request =
       job_info->GetActiveRequest(request_guid);
   DCHECK(request);
   request->set_download_guid(download_guid);
 }
 
 }  // namespace content