DescriptionExport all CWV* symbols from the ios/web_view dynamic library.
Only symbols explicitly marked __attribute__((visibility("default"))) are
exported from a dynamic library. So all public classes in ios/web_view
must be marked as __attribute__((visibility("default"))). Otherwise the
users of the dynamic library cannot access these classes.
Here I followed other code using __attribute__((visibility("default")))
in Chromium like this one:
https://cs.chromium.org/chromium/src/dbus/dbus_export.h
to define a macro CWV_EXPORT instead of directly using __attribute__.
This makes it possible to export symbols only when *building* the dynamic
library (by checking CWV_IMPLEMENTATION), not when *using* the dynamic
library.
BUG=704043
Review-Url: https://codereview.chromium.org/2770633002
Cr-Commit-Position: refs/heads/master@{#460017}
Committed: https://chromium.googlesource.com/chromium/src/+/a548ad0c0108bc06d5e622acfc89777bcb00ee23
Patch Set 1 #
Total comments: 16
Patch Set 2 : Apply review comments. #
Total comments: 2
Patch Set 3 : Break a line after CWV_EXPORT. #Patch Set 4 : Apply review comments. #
Total comments: 6
Patch Set 5 : Apply review comments. #Patch Set 6 : Add TODO comment. #Patch Set 7 : Rebase. #Patch Set 8 : Add cwv_export.h to "sources" attribute of //ios/web_view:web_view. #
Total comments: 3
Messages
Total messages: 39 (17 generated)
|