Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: ios/web_view/internal/translate/BUILD.gn

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)
Patch Set: Add cwv_export.h to "sources" attribute of //ios/web_view:web_view. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/translate/BUILD.gn
diff --git a/ios/web_view/internal/translate/BUILD.gn b/ios/web_view/internal/translate/BUILD.gn
index d42ff359291154da48a5cadc094bff39af71267f..fdbfd6dc5a1997aa5a645f75e2cd16154f733fc2 100644
--- a/ios/web_view/internal/translate/BUILD.gn
+++ b/ios/web_view/internal/translate/BUILD.gn
@@ -16,6 +16,11 @@ source_set("translate") {
"web_view_translate_client.h",
"web_view_translate_client.mm",
]
+
+ # Let header files know that it is building ios/web_view library, not using
+ # it.
+ defines = [ "CWV_IMPLEMENTATION" ]
+
deps = [
"//base",
"//components/infobars/core",

Powered by Google App Engine
This is Rietveld 408576698