Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: ios/web_view/BUILD.gn

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)
Patch Set: Add cwv_export.h to "sources" attribute of //ios/web_view:web_view. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web_view/internal/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/BUILD.gn
diff --git a/ios/web_view/BUILD.gn b/ios/web_view/BUILD.gn
index 9fe80afee29e4d326af0b112dc4a56c4561a6a71..4ca4bd207e86bb46dff340c5a17353c2fae8c096 100644
--- a/ios/web_view/BUILD.gn
+++ b/ios/web_view/BUILD.gn
@@ -19,12 +19,14 @@ ios_framework_bundle("web_view") {
sources = [
"public/cwv.h",
+ "public/cwv_export.h",
Hiroshi Ichikawa 2017/03/28 04:35:02 I needed to add this here too, otherwise it causes
sdefresne 2017/03/28 10:29:26 public_headers are not automatically added to sour
michaeldo 2017/03/28 17:34:19 I think it's fine to only have cwv_export.h in sou
]
public_headers = [
"public/criwv_translate_manager.h",
"public/cwv.h",
"public/cwv_delegate.h",
+ "public/cwv_export.h",
"public/cwv_html_element.h",
"public/cwv_navigation_action.h",
"public/cwv_navigation_delegate.h",
« no previous file with comments | « no previous file | ios/web_view/internal/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698