Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: ios/web_view/BUILD.gn

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)
Patch Set: Add cwv_export.h to "sources" attribute of //ios/web_view:web_view. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/web_view/internal/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/ios_sdk.gni") 5 import("//build/config/ios/ios_sdk.gni")
6 import("//build/config/ios/rules.gni") 6 import("//build/config/ios/rules.gni")
7 import("//tools/grit/repack.gni") 7 import("//tools/grit/repack.gni")
8 8
9 config("config") { 9 config("config") {
10 include_dirs = [ 10 include_dirs = [
11 "internal", 11 "internal",
12 "public", 12 "public",
13 ] 13 ]
14 } 14 }
15 15
16 ios_framework_bundle("web_view") { 16 ios_framework_bundle("web_view") {
17 output_name = "ChromeWebView" 17 output_name = "ChromeWebView"
18 info_plist = "Info.plist" 18 info_plist = "Info.plist"
19 19
20 sources = [ 20 sources = [
21 "public/cwv.h", 21 "public/cwv.h",
22 "public/cwv_export.h",
Hiroshi Ichikawa 2017/03/28 04:35:02 I needed to add this here too, otherwise it causes
sdefresne 2017/03/28 10:29:26 public_headers are not automatically added to sour
michaeldo 2017/03/28 17:34:19 I think it's fine to only have cwv_export.h in sou
22 ] 23 ]
23 24
24 public_headers = [ 25 public_headers = [
25 "public/criwv_translate_manager.h", 26 "public/criwv_translate_manager.h",
26 "public/cwv.h", 27 "public/cwv.h",
27 "public/cwv_delegate.h", 28 "public/cwv_delegate.h",
29 "public/cwv_export.h",
28 "public/cwv_html_element.h", 30 "public/cwv_html_element.h",
29 "public/cwv_navigation_action.h", 31 "public/cwv_navigation_action.h",
30 "public/cwv_navigation_delegate.h", 32 "public/cwv_navigation_delegate.h",
31 "public/cwv_translate_delegate.h", 33 "public/cwv_translate_delegate.h",
32 "public/cwv_ui_delegate.h", 34 "public/cwv_ui_delegate.h",
33 "public/cwv_user_content_controller.h", 35 "public/cwv_user_content_controller.h",
34 "public/cwv_user_script.h", 36 "public/cwv_user_script.h",
35 "public/cwv_web_view.h", 37 "public/cwv_web_view.h",
36 "public/cwv_web_view_configuration.h", 38 "public/cwv_web_view_configuration.h",
37 ] 39 ]
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 public_deps = [ 89 public_deps = [
88 ":repack_resources", 90 ":repack_resources",
89 ] 91 ]
90 sources = [ 92 sources = [
91 "$target_gen_dir/web_view_resources.pak", 93 "$target_gen_dir/web_view_resources.pak",
92 ] 94 ]
93 outputs = [ 95 outputs = [
94 "{{bundle_resources_dir}}/{{source_file_part}}", 96 "{{bundle_resources_dir}}/{{source_file_part}}",
95 ] 97 ]
96 } 98 }
OLDNEW
« no previous file with comments | « no previous file | ios/web_view/internal/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698