ios/web_view/public/criwv_translate_manager.h - Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web_view/public/criwv_translate_manager.h

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)

Patch Set: Apply review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_WEB_VIEW_PUBLIC_CRIWV_TRANSLATE_MANAGER_H_	5 #ifndef IOS_WEB_VIEW_PUBLIC_CRIWV_TRANSLATE_MANAGER_H_

6 #define IOS_WEB_VIEW_PUBLIC_CRIWV_TRANSLATE_MANAGER_H_	6 #define IOS_WEB_VIEW_PUBLIC_CRIWV_TRANSLATE_MANAGER_H_

7	7

8 #import <Foundation/Foundation.h>	8 #import <Foundation/Foundation.h>

9	9

	10 #if defined(CWV_IMPLEMENTATION)
	Eugene But (OOO till 7-30) 2017/03/24 16:39:20 This is quite ugly for a public framework header. This is quite ugly for a public framework header. WKWebView.h header does not have these ifdefs, so can we do the same thing? ChromeWebView only supports dynamic linking and if we ever need to support static linking, then we can add ifdefs back. WDYT? Hiroshi Ichikawa 2017/03/27 02:09:25 This is currently necessary, even just to support Show quoted text On 2017/03/24 16:39:20, Eugene But wrote: > This is quite ugly for a public framework header. WKWebView.h header does not > have these ifdefs, so can we do the same thing? ChromeWebView only supports > dynamic linking and if we ever need to support static linking, then we can add > ifdefs back. WDYT? This is currently necessary, even just to support dynamic framework. Pasting my comment to another comment for reference: Show quoted text > Do you mean that > #include <ChromeWebView/cwv_export.h> > should work while building the framework? > > Currently it doesn't work, causing this error: > > In file included from ../../ios/web_view/internal/cwv.mm:5: > ../../ios/web_view/public/cwv.h:14:10: fatal error: 'ChromeWebView/cwv_export.h' Show quoted text > file not found We are trying to find a solution, but can I leave it as is and submit this until we find a solution? Added a TODO comment.
	11 #include "ios/web_view/public/cwv_export.h"

	12 #else

	13 #include <ChromeWebView/cwv_export.h>

	14 #endif

	15

10 // Interface to manage the translation flow.	16 // Interface to manage the translation flow.

11 // Clients are not supposed to instantiate or subclass it.	17 // Clients are not supposed to instantiate or subclass it.

	18 CWV_EXPORT

12 @protocol CRIWVTranslateManager<NSObject>	19 @protocol CRIWVTranslateManager<NSObject>

13	20

14 - (void)translate;	21 - (void)translate;

15	22

16 - (void)revertTranslation;	23 - (void)revertTranslation;

17	24

18 @end	25 @end

19	26

20 #endif // IOS_WEB_VIEW_PUBLIC_CRIWV_TRANSLATE_MANAGER_H_	27 #endif // IOS_WEB_VIEW_PUBLIC_CRIWV_TRANSLATE_MANAGER_H_

OLD	NEW

« ios/web_view/internal/BUILD.gn ('K') | « ios/web_view/public/BUILD.gn ('k') | ios/web_view/public/cwv.h » ('j') | ios/web_view/shell/BUILD.gn » ('J')