ios/web_view/public/cwv_export.h - Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web_view/public/cwv_export.h

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)

Patch Set: Apply review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_EXPORT_H_

	6 #define IOS_WEB_VIEW_PUBLIC_CWV_EXPORT_H_

	7

	8 // All public classes in //ios/web_view must be prefixed with CWV_EXPORT, so

	9 // that clients of //ios/web_view dynamic library can link them.

	10 //

	11 // This is because a dynamic library only exports symbols marked

	12 // __attribute__((visibility("default"))).

	13 //

	14 // Here I define a macro CWV_EXPORT instead of directly using __attribute__.
	michaeldo 2017/03/23 15:12:42 Remove "Here I". I can't find the reference, but w Remove "Here I". I can't find the reference, but we don't use "we" in comments, and I don't believe we should have I in them either since it is arbitrary. Hiroshi Ichikawa 2017/03/24 06:34:20 Done. Show quoted text On 2017/03/23 15:12:42, michaeldo wrote: > Remove "Here I". I can't find the reference, but we don't use "we" in comments, > and I don't believe we should have I in them either since it is arbitrary. Done.
	15 // This makes it possible to export symbols only when building the dynamic

	16 // library (by checking CWV_IMPLEMENTATION), not when using the dynamic

	17 // library.

	18 #if defined(CWV_IMPLEMENTATION)

	19 #define CWV_EXPORT __attribute__((visibility("default")))

	20 #else

	21 #define CWV_EXPORT

	22 #endif

	23

	24 #endif // IOS_WEB_VIEW_PUBLIC_CWV_EXPORT_H_

OLD	NEW

« no previous file with comments | « ios/web_view/public/cwv_delegate.h ('k') | ios/web_view/public/cwv_html_element.h » ('j') | no next file with comments »