Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Created:
3 years, 9 months ago by Bugs Nash
Modified:
3 years, 9 months ago
CC:
ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, fmalita+watch_chromium.org, gavinp+loader_chromium.org, Nate Chapin, jbroman, Justin Novosad, kinuko+watch, kinuko+fileapi, kozyatinskiy+blink_chromium.org, leviw+bidiwatch_chromium.org, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, Mikhail, nhiroki, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, tyoshino+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wrapped PassRefPtrs in move where passed to RefPtr constructor. Part of the removal of PassRefPtr. Added std::move wraps to PassRefPtr objects that are passed to a RefPtr constructor. These PassRefPtr objects will eventually be replaced with RefPtr objects, and these places would introduce ref churn when that happens without the std::move wraps. BUG=494719 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2761693002 Cr-Commit-Position: refs/heads/master@{#458323} Committed: https://chromium.googlesource.com/chromium/src/+/f2c7dc50ceb57308a7c293562e1780fd8013c8fd

Patch Set 1 #

Patch Set 2 : Added move wraps for multiple instances in 1 line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -110 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SizeInterpolationFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint3D.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableSVGPaint.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPathValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ClipPathOperation.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ShapeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/SharedBufferReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKey.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODArena.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SerializedResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobData.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCacheKey.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/SegmentReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/SubstituteData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/ArchiveResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/EncodedFormData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFileChooserCompletionImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Bugs Nash
3 years, 9 months ago (2017-03-20 02:39:38 UTC) #8
haraken
LGTM
3 years, 9 months ago (2017-03-20 02:53:56 UTC) #9
Bugs Nash
+alancutter@ for Source/core/animations
3 years, 9 months ago (2017-03-20 04:15:07 UTC) #13
Yuta Kitamura
lgtm
3 years, 9 months ago (2017-03-21 01:55:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761693002/20001
3 years, 9 months ago (2017-03-21 02:37:13 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 05:59:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2c7dc50ceb57308a7c293562e17...

Powered by Google App Engine
This is Rietveld 408576698