third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp - Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp b/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

index 33c66ce31cfd02e8763f2318b4c145b209e3b25f..f03f078b8837ce473069db8a7cba083a3ffc74a7 100644

--- a/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

+++ b/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

@@ -65,7 +65,7 @@ SimpleFontData::SimpleFontData(const FontPlatformData& platformData,

m_isTextOrientationFallback(isTextOrientationFallback),

m_verticalData(nullptr),

m_hasVerticalGlyphs(false),

- m_customFontData(customData) {

+ m_customFontData(std::move(customData)) {

platformInit(subpixelAscentDescent);

platformGlyphInit();

if (platformData.isVerticalAnyUpright() && !isTextOrientationFallback) {

@@ -84,7 +84,7 @@ SimpleFontData::SimpleFontData(PassRefPtr<CustomFontData> customData,

m_isTextOrientationFallback(false),

m_verticalData(nullptr),

m_hasVerticalGlyphs(false),

- m_customFontData(customData) {}

+ m_customFontData(std::move(customData)) {}

void SimpleFontData::platformInit(bool subpixelAscentDescent) {

if (!m_platformData.size()) {