third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp - Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp ('k') | third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

index a66f431ae397f6fcf92252cd439fd64584ab86d2..6686095f97acace5a6c428e6206d46047225e7f0 100644

--- a/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

@@ -29,7 +29,8 @@ class UnderlyingCompatibilityChecker

private:

UnderlyingCompatibilityChecker(

PassRefPtr<NonInterpolableValue> underlyingNonInterpolableValue)

- : m_underlyingNonInterpolableValue(underlyingNonInterpolableValue) {}

+ : m_underlyingNonInterpolableValue(

+ std::move(underlyingNonInterpolableValue)) {}

bool isValid(const InterpolationEnvironment&,

const InterpolationValue& underlying) const final {

@@ -52,7 +53,7 @@ class InheritedShapeChecker : public InterpolationType::ConversionChecker {

private:

InheritedShapeChecker(CSSPropertyID property,

PassRefPtr<BasicShape> inheritedShape)

- : m_property(property), m_inheritedShape(inheritedShape) {}

+ : m_property(property), m_inheritedShape(std::move(inheritedShape)) {}

bool isValid(const InterpolationEnvironment& environment,

const InterpolationValue&) const final {