third_party/WebKit/Source/wtf/text/WTFString.h - Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/WTFString.h

diff --git a/third_party/WebKit/Source/wtf/text/WTFString.h b/third_party/WebKit/Source/wtf/text/WTFString.h

index dd517e4a369d0d03aa5a48315c5d83326481c403..a071bf21580a33f5ae24f17a44e735c8ae194af1 100644

--- a/third_party/WebKit/Source/wtf/text/WTFString.h

+++ b/third_party/WebKit/Source/wtf/text/WTFString.h

@@ -97,7 +97,7 @@ class WTF_EXPORT String {

// Construct a string referencing an existing StringImpl.

String(StringImpl* impl) : m_impl(impl) {}

- String(PassRefPtr<StringImpl> impl) : m_impl(impl) {}

+ String(PassRefPtr<StringImpl> impl) : m_impl(std::move(impl)) {}

void swap(String& o) { m_impl.swap(o.m_impl); }