third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp - Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

index e70b14952019d4fda545bfc93f0473316598356c..28df7e726ee62c2762fff0f913dbc1123fff7d1e 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

@@ -46,7 +46,7 @@ FELighting::FELighting(Filter* filter,

PassRefPtr<LightSource> lightSource)

: FilterEffect(filter),

m_lightingType(lightingType),

- m_lightSource(lightSource),

+ m_lightSource(std::move(lightSource)),

m_lightingColor(lightingColor),

m_surfaceScale(surfaceScale),

m_diffuseConstant(std::max(diffuseConstant, 0.0f)),