Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)
Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ScriptState.h" 5 #include "bindings/core/v8/ScriptState.h"
6 6
7 #include "bindings/core/v8/V8Binding.h" 7 #include "bindings/core/v8/V8Binding.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/LocalDOMWindow.h" 9 #include "core/frame/LocalDOMWindow.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
(...skipping 17 matching lines...) Expand all
28 static void contextCollectedCallback( 28 static void contextCollectedCallback(
29 const v8::WeakCallbackInfo<ScriptState>& data) { 29 const v8::WeakCallbackInfo<ScriptState>& data) {
30 data.GetParameter()->clearContext(); 30 data.GetParameter()->clearContext();
31 data.SetSecondPassCallback(derefCallback); 31 data.SetSecondPassCallback(derefCallback);
32 } 32 }
33 33
34 ScriptState::ScriptState(v8::Local<v8::Context> context, 34 ScriptState::ScriptState(v8::Local<v8::Context> context,
35 PassRefPtr<DOMWrapperWorld> world) 35 PassRefPtr<DOMWrapperWorld> world)
36 : m_isolate(context->GetIsolate()), 36 : m_isolate(context->GetIsolate()),
37 m_context(m_isolate, context), 37 m_context(m_isolate, context),
38 m_world(world), 38 m_world(std::move(world)),
39 m_perContextData(V8PerContextData::create(context)) 39 m_perContextData(V8PerContextData::create(context)) {
40 {
41 DCHECK(m_world); 40 DCHECK(m_world);
42 m_context.setWeak(this, &contextCollectedCallback); 41 m_context.setWeak(this, &contextCollectedCallback);
43 context->SetAlignedPointerInEmbedderData(v8ContextPerContextDataIndex, this); 42 context->SetAlignedPointerInEmbedderData(v8ContextPerContextDataIndex, this);
44 } 43 }
45 44
46 ScriptState::~ScriptState() { 45 ScriptState::~ScriptState() {
47 ASSERT(!m_perContextData); 46 ASSERT(!m_perContextData);
48 ASSERT(m_context.isEmpty()); 47 ASSERT(m_context.isEmpty());
49 } 48 }
50 49
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 v8::HandleScope handleScope(toIsolate(frame)); 90 v8::HandleScope handleScope(toIsolate(frame));
92 v8::Local<v8::Context> context = toV8Context(frame, world); 91 v8::Local<v8::Context> context = toV8Context(frame, world);
93 if (context.IsEmpty()) 92 if (context.IsEmpty())
94 return nullptr; 93 return nullptr;
95 ScriptState* scriptState = ScriptState::from(context); 94 ScriptState* scriptState = ScriptState::from(context);
96 ASSERT(scriptState->contextIsValid()); 95 ASSERT(scriptState->contextIsValid());
97 return scriptState; 96 return scriptState;
98 } 97 }
99 98
100 } // namespace blink 99 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698