Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-apply rolled back CL to apply dartfmt to runtime. Fix observatory tests broken by running dartfmt due to line and column changes. Temporarily reverted formatting for evaluate_activation_test.dart as dartfmt doesn't yet handle multitests. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/88f8aacd5fbe05591a109b1f04054334bf16d040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13328 lines, -8389 lines) Patch
M runtime/bin/builtin.dart View 7 chunks +17 lines, -25 lines 0 comments Download
M runtime/bin/common_patch.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/bin/directory_patch.dart View 1 chunk +32 lines, -22 lines 0 comments Download
M runtime/bin/eventhandler_patch.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/bin/file_patch.dart View 20 chunks +89 lines, -76 lines 0 comments Download
M runtime/bin/file_system_entity_patch.dart View 1 chunk +12 lines, -10 lines 0 comments Download
M runtime/bin/filter_patch.dart View 2 chunks +13 lines, -16 lines 0 comments Download
M runtime/bin/io_service_patch.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/bin/platform_patch.dart View 1 chunk +24 lines, -22 lines 0 comments Download
M runtime/bin/process_patch.dart View 20 chunks +194 lines, -202 lines 0 comments Download
M runtime/bin/secure_socket_patch.dart View 12 chunks +55 lines, -44 lines 0 comments Download
M runtime/bin/socket_patch.dart View 31 chunks +398 lines, -470 lines 0 comments Download
M runtime/bin/stdio_patch.dart View 8 chunks +33 lines, -18 lines 0 comments Download
M runtime/bin/vmservice/server.dart View 11 chunks +15 lines, -23 lines 0 comments Download
M runtime/bin/vmservice/vmservice_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/array.dart View 7 chunks +7 lines, -11 lines 0 comments Download
M runtime/lib/array_patch.dart View 3 chunks +15 lines, -7 lines 0 comments Download
M runtime/lib/async_patch.dart View 4 chunks +15 lines, -14 lines 0 comments Download
M runtime/lib/bigint.dart View 62 chunks +209 lines, -179 lines 0 comments Download
M runtime/lib/bool_patch.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/lib/collection_patch.dart View 21 chunks +50 lines, -40 lines 0 comments Download
M runtime/lib/compact_hash.dart View 22 chunks +43 lines, -37 lines 0 comments Download
M runtime/lib/core_patch.dart View 3 chunks +9 lines, -8 lines 0 comments Download
M runtime/lib/date_patch.dart View 12 chunks +79 lines, -67 lines 0 comments Download
M runtime/lib/deferred_load_patch.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/lib/developer.dart View 6 chunks +49 lines, -54 lines 0 comments Download
M runtime/lib/double.dart View 7 chunks +34 lines, -9 lines 0 comments Download
M runtime/lib/double_patch.dart View 4 chunks +15 lines, -15 lines 0 comments Download
M runtime/lib/errors_patch.dart View 12 chunks +131 lines, -117 lines 0 comments Download
M runtime/lib/expando_patch.dart View 7 chunks +15 lines, -11 lines 0 comments Download
M runtime/lib/function.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/function_patch.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/lib/growable_array.dart View 5 chunks +6 lines, -8 lines 0 comments Download
M runtime/lib/identical_patch.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/lib/immutable_map.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/lib/internal_patch.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/lib/invocation_mirror_patch.dart View 4 chunks +11 lines, -20 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 18 chunks +163 lines, -129 lines 0 comments Download
M runtime/lib/map_patch.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M runtime/lib/math_patch.dart View 8 chunks +38 lines, -28 lines 0 comments Download
M runtime/lib/mirrors_patch.dart View 4 chunks +17 lines, -9 lines 0 comments Download
M runtime/lib/null_patch.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/lib/object_patch.dart View 2 chunks +20 lines, -18 lines 0 comments Download
M runtime/lib/print_patch.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/lib/profiler.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 9 chunks +26 lines, -33 lines 0 comments Download
M runtime/lib/schedule_microtask_patch.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/lib/stacktrace.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/stopwatch_patch.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/lib/string_buffer_patch.dart View 5 chunks +24 lines, -15 lines 0 comments Download
M runtime/lib/string_patch.dart View 28 chunks +68 lines, -80 lines 0 comments Download
M runtime/lib/symbol_patch.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/lib/timeline.dart View 1 chunk +19 lines, -23 lines 0 comments Download
M runtime/lib/timer_impl.dart View 19 chunks +17 lines, -46 lines 0 comments Download
M runtime/lib/timer_patch.dart View 3 chunks +12 lines, -8 lines 0 comments Download
M runtime/lib/type_patch.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M runtime/lib/uri_patch.dart View 2 chunks +15 lines, -11 lines 0 comments Download
M runtime/lib/vmservice_patch.dart View 2 chunks +24 lines, -14 lines 0 comments Download
M runtime/observatory/lib/event.dart View 3 chunks +2 lines, -7 lines 0 comments Download
M runtime/observatory/lib/object_graph.dart View 9 chunks +19 lines, -24 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/cli/command.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 12 chunks +26 lines, -40 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 5 chunks +7 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 5 chunks +15 lines, -21 lines 0 comments Download
M runtime/observatory/lib/src/elements/stack_trace_tree_config.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/frame.dart View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/heap_snapshot.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/repositories/heap_snapshot.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart View 5 chunks +55 lines, -51 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/class_tree/element_test.dart View 3 chunks +19 lines, -11 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/context_view/element_test.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile/element_test.dart View 2 chunks +17 lines, -25 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile_table/element_test.dart View 2 chunks +17 lines, -25 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/curly_block/element_test.dart View 5 chunks +6 lines, -9 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/error_ref/element_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/field_ref/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/flag_list/element_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/general_error/element_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/heap_snapshot/element_test.dart View 1 chunk +19 lines, -26 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/icdata_view/element_test.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart View 1 chunk +12 lines, -14 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate_reconnect/element_test.dart View 2 chunks +17 lines, -14 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart View 1 chunk +29 lines, -14 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart View 2 chunks +15 lines, -11 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/class.dart View 1 chunk +23 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/code.dart View 2 chunks +12 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/context.dart View 1 chunk +10 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/error.dart View 2 chunks +11 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/event.dart View 2 chunks +45 lines, -18 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/field.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/function.dart View 2 chunks +30 lines, -9 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/guarded.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/heap_snapshot.dart View 5 chunks +27 lines, -16 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/heap_space.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/icdata.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/inbound_references.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart View 2 chunks +51 lines, -22 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 chunk +16 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/library.dart View 1 chunk +16 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/local_var_descriptors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/megamorphiccache.dart View 2 chunks +11 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart View 2 chunks +12 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/objectstore.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/pc_descriptors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/persistent_handles.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/ports.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/retaining_path.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/sample_profile.dart View 2 chunks +10 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/script.dart View 1 chunk +17 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/unknown.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/vm.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/allocation_profile.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/class.dart View 1 chunk +9 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/context.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/eval.dart View 1 chunk +5 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/event.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/field.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/flag.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/heap_snapshot.dart View 1 chunk +14 lines, -11 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/icdata.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/inbound_references.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/instance.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/library.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/megamorphiccache.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/notification.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/objectpool.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/objectstore.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/persistent_handles.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/ports.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/reachable_size.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/retained_size.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/retaining_path.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/sample_profile.dart View 4 chunks +25 lines, -22 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/script.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/target.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify/element_test.dart View 2 chunks +10 lines, -11 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/exception_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/top_menu/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.dart View 2 chunks +13 lines, -9 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/object_common/element_test.dart View 4 chunks +18 lines, -26 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/objectpool_view/element_test.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/objectstore_view/element_test.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.dart View 1 chunk +8 lines, -9 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/ports/element_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/retaining_path/element_test.dart View 1 chunk +8 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart View 4 chunks +23 lines, -31 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/script_ref/element_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/source_link/element_test.dart View 2 chunks +15 lines, -14 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/vm_connect/element_test.dart View 6 chunks +24 lines, -19 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/add_breakpoint_rpc_test.dart View 7 chunks +18 lines, -22 lines 0 comments Download
M runtime/observatory/tests/service/allocations_test.dart View 2 chunks +13 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/async_generator_breakpoint_test.dart View 3 chunks +21 lines, -19 lines 0 comments Download
M runtime/observatory/tests/service/async_next_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/async_scope_test.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/auth_token1_test.dart View 1 chunk +12 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/auth_token_test.dart View 1 chunk +12 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/bad_reload_test.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/bad_web_socket_address_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/break_on_activation_test.dart View 1 chunk +153 lines, -155 lines 0 comments Download
M runtime/observatory/tests/service/break_on_function_test.dart View 2 chunks +18 lines, -18 lines 0 comments Download
M runtime/observatory/tests/service/breakpoint_two_args_checked_test.dart View 1 chunk +38 lines, -40 lines 0 comments Download
M runtime/observatory/tests/service/caching_test.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/capture_stdio_test.dart View 1 chunk +29 lines, -38 lines 0 comments Download
M runtime/observatory/tests/service/causal_async_stack_contents_test.dart View 4 chunks +5 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/causal_async_stack_presence_test.dart View 3 chunks +5 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/causal_async_star_stack_contents_test.dart View 4 chunks +5 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/causal_async_star_stack_presence_test.dart View 3 chunks +5 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 4 chunks +21 lines, -21 lines 0 comments Download
M runtime/observatory/tests/service/command_test.dart View 7 chunks +42 lines, -46 lines 0 comments Download
M runtime/observatory/tests/service/complex_reload/v1/main.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/complex_reload_test.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 2 chunks +79 lines, -82 lines 0 comments Download
M runtime/observatory/tests/service/crash_dump_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugger_inspect_test.dart View 1 chunk +16 lines, -18 lines 0 comments Download
M runtime/observatory/tests/service/debugger_location_second_test.dart View 4 chunks +127 lines, -127 lines 0 comments Download
M runtime/observatory/tests/service/debugger_location_test.dart View 4 chunks +77 lines, -79 lines 0 comments Download
M runtime/observatory/tests/service/debugging_inlined_finally_test.dart View 2 chunks +74 lines, -76 lines 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 2 chunks +162 lines, -161 lines 0 comments Download
M runtime/observatory/tests/service/deferred_library.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_http_put_test.dart View 5 chunks +6 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_http_put_weird_char_test.dart View 5 chunks +6 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_spawn_test.dart View 8 chunks +60 lines, -69 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_test.dart View 8 chunks +26 lines, -32 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_uri_test.dart View 5 chunks +7 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_weird_char_test.dart View 2 chunks +7 lines, -10 lines 0 comments Download
M runtime/observatory/tests/service/developer_server_control_test.dart View 1 chunk +11 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/developer_service_get_isolate_id_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/dominator_tree_user_test.dart View 2 chunks +101 lines, -47 lines 0 comments Download
M runtime/observatory/tests/service/dominator_tree_vm_test.dart View 2 chunks +101 lines, -47 lines 0 comments Download
M runtime/observatory/tests/service/echo_test.dart View 1 chunk +27 lines, -31 lines 0 comments Download
M runtime/observatory/tests/service/eval_internal_class_test.dart View 1 chunk +27 lines, -29 lines 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 2 chunks +20 lines, -22 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_async_activation_test.dart View 1 chunk +26 lines, -33 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart View 1 chunk +26 lines, -33 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_frame_rpc_test.dart View 1 chunk +12 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_sync_star_activation_test.dart View 1 chunk +26 lines, -33 lines 0 comments Download
M runtime/observatory/tests/service/field_script_other.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/field_script_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/file_service_test.dart View 5 chunks +6 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/gc_test.dart View 1 chunk +16 lines, -18 lines 0 comments Download
M runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart View 4 chunks +13 lines, -17 lines 0 comments Download
M runtime/observatory/tests/service/get_allocation_samples_test.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_cpu_profile_timeline_rpc_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_flag_list_rpc_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/get_heap_map_rpc_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_instances_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_isolate_after_async_error_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_isolate_after_stack_overflow_error_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_isolate_after_sync_error_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_isolate_rpc_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 15 chunks +41 lines, -42 lines 0 comments Download
M runtime/observatory/tests/service/get_object_store_rpc_test.dart View 1 chunk +20 lines, -21 lines 0 comments Download
M runtime/observatory/tests/service/get_ports_rpc_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_retained_size_rpc_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_retaining_path_rpc_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/get_source_report_test.dart View 1 chunk +123 lines, -107 lines 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 2 chunks +48 lines, -50 lines 0 comments Download
M runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/implicit_getter_setter_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/inbound_references_test.dart View 3 chunks +10 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/instance_field_order_rpc_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 5 chunks +4 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/issue_25465_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/issue_27238_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/issue_27287_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/library_dependency_test.dart View 1 chunk +25 lines, -27 lines 0 comments Download
M runtime/observatory/tests/service/local_variable_declaration_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/logging_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/malformed_test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/metrics_test.dart View 2 chunks +6 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/mirror_references_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/native_metrics_test.dart View 1 chunk +11 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/next_through_catch_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/next_through_for_each_loop_test.dart View 2 chunks +11 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/next_through_for_loop_with_break_and_continue_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/next_through_function_expression_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/object_graph_stack_reference_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/object_graph_user_test.dart View 3 chunks +57 lines, -62 lines 0 comments Download
M runtime/observatory/tests/service/object_graph_vm_test.dart View 3 chunks +57 lines, -62 lines 0 comments Download
M runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/pause_idle_isolate_test.dart View 1 chunk +28 lines, -32 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_exceptions_test.dart View 1 chunk +71 lines, -75 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_and_exit_test.dart View 1 chunk +59 lines, -63 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 1 chunk +60 lines, -64 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart View 3 chunks +6 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_unhandled_async_exceptions_test.dart View 3 chunks +10 lines, -18 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/positive_token_pos_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/process_service_test.dart View 4 chunks +16 lines, -18 lines 0 comments Download
M runtime/observatory/tests/service/reachable_size_test.dart View 1 chunk +21 lines, -21 lines 0 comments Download
M runtime/observatory/tests/service/read_stream_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/regexp_function_test.dart View 1 chunk +32 lines, -34 lines 0 comments Download
M runtime/observatory/tests/service/regress_28443_test.dart View 2 chunks +16 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/reload_sources_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/rewind_optimized_out_test.dart View 2 chunks +19 lines, -20 lines 0 comments Download
M runtime/observatory/tests/service/rewind_test.dart View 6 chunks +15 lines, -30 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 11 chunks +45 lines, -56 lines 0 comments Download
M runtime/observatory/tests/service/set_library_debuggable_rpc_test.dart View 5 chunks +18 lines, -19 lines 0 comments Download
M runtime/observatory/tests/service/set_library_debuggable_test.dart View 2 chunks +13 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/set_name_rpc_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/set_vm_name_rpc_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/smart_next_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/steal_breakpoint_test.dart View 1 chunk +45 lines, -46 lines 0 comments Download
M runtime/observatory/tests/service/step_into_async_no_await_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/step_over_await_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/step_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/string_escaping_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/tcp_socket_closing_service_test.dart View 5 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/tcp_socket_service_test.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 14 chunks +126 lines, -125 lines 0 comments Download
M runtime/observatory/tests/service/type_arguments_test.dart View 1 chunk +33 lines, -28 lines 0 comments Download
M runtime/observatory/tests/service/typed_data_test.dart View 3 chunks +1 line, -2 lines 0 comments Download
M runtime/observatory/tests/service/udp_socket_service_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/vm_test.dart View 1 chunk +5 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/vm_timeline_events_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/vm_timeline_flags_test.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M runtime/observatory/tests/service/weak_properties_test.dart View 4 chunks +8 lines, -6 lines 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 6 chunks +24 lines, -10 lines 0 comments Download
M runtime/observatory/tests/ui/inspector_part.dart View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/observatory/tests/ui/log.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/tests/vm/dart/byte_array_optimized_test.dart View 51 chunks +3551 lines, -1215 lines 0 comments Download
M runtime/tests/vm/dart/byte_array_test.dart View 56 chunks +3819 lines, -1333 lines 0 comments Download
M runtime/tests/vm/dart/data_uri_spawn_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/dart/double_materialize_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/tests/vm/dart/hello_fuchsia_test.dart View 10 chunks +34 lines, -24 lines 0 comments Download
M runtime/tests/vm/dart/inline_stack_frame_test.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart View 4 chunks +12 lines, -9 lines 0 comments Download
M runtime/tests/vm/dart/optimized_stacktrace_line_test.dart View 4 chunks +6 lines, -7 lines 0 comments Download
M runtime/tests/vm/dart/random_walk_fuzzer.dart View 8 chunks +26 lines, -24 lines 0 comments Download
M runtime/tests/vm/dart/redirection_type_shuffling_test.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M runtime/tests/vm/dart/spawn_shutdown_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/tools/verbose_gc_to_bmu.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/snapshot_test.dart View 41 chunks +77 lines, -88 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jacob
3 years, 9 months ago (2017-03-20 22:53:17 UTC) #2
Jacob
3 years, 9 months ago (2017-03-20 22:53:37 UTC) #4
Cutch
lgtm
3 years, 9 months ago (2017-03-20 23:02:27 UTC) #5
Jacob
3 years, 9 months ago (2017-03-21 04:45:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88f8aacd5fbe05591a109b1f04054334bf16d040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698