Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Side by Side Diff: runtime/observatory/tests/service/get_ports_rpc_test.dart

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 library get_ports_rpc_test; 6 library get_ports_rpc_test;
7 7
8 import 'dart:isolate' hide Isolate; 8 import 'dart:isolate' hide Isolate;
9 import 'package:observatory/service_io.dart'; 9 import 'package:observatory/service_io.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
11 11
12 import 'test_helper.dart'; 12 import 'test_helper.dart';
13 13
14 var port1; 14 var port1;
15 var port2; 15 var port2;
16 16
17 void warmup() { 17 void warmup() {
18 port1 = new RawReceivePort(null); 18 port1 = new RawReceivePort(null);
19 port2 = new RawReceivePort((_) { 19 port2 = new RawReceivePort((_) {});
20 });
21 } 20 }
22 21
23 int countHandlerMatches(ports, matcher) { 22 int countHandlerMatches(ports, matcher) {
24 var matches = 0; 23 var matches = 0;
25 for (var port in ports) { 24 for (var port in ports) {
26 if (matcher(port['handler'])) { 25 if (matcher(port['handler'])) {
27 matches++; 26 matches++;
28 } 27 }
29 } 28 }
30 return matches; 29 return matches;
(...skipping 14 matching lines...) Expand all
45 expect(result['ports'], isList); 44 expect(result['ports'], isList);
46 var ports = result['ports']; 45 var ports = result['ports'];
47 // There are at least two ports: the two created in warm up. Some OSes 46 // There are at least two ports: the two created in warm up. Some OSes
48 // will have other ports open but we do not try and test for these. 47 // will have other ports open but we do not try and test for these.
49 expect(ports.length, greaterThanOrEqualTo(2)); 48 expect(ports.length, greaterThanOrEqualTo(2));
50 expect(countHandlerMatches(ports, nullMatcher), greaterThanOrEqualTo(1)); 49 expect(countHandlerMatches(ports, nullMatcher), greaterThanOrEqualTo(1));
51 expect(countHandlerMatches(ports, closureMatcher), greaterThanOrEqualTo(1)); 50 expect(countHandlerMatches(ports, closureMatcher), greaterThanOrEqualTo(1));
52 }, 51 },
53 ]; 52 ];
54 53
55 main(args) async => runIsolateTests(args, tests, testeeBefore:warmup); 54 main(args) async => runIsolateTests(args, tests, testeeBefore: warmup);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698