Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: runtime/observatory/tests/service/metrics_test.dart

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
7 import 'package:unittest/unittest.dart'; 7 import 'package:unittest/unittest.dart';
8 import 'test_helper.dart'; 8 import 'test_helper.dart';
9 9
10 import 'dart:developer'; 10 import 'dart:developer';
11 11
12 void script() { 12 void script() {
13 var counter = new Counter('a.b.c', 'description'); 13 var counter = new Counter('a.b.c', 'description');
14 Metrics.register(counter); 14 Metrics.register(counter);
15 counter.value = 1234.5; 15 counter.value = 1234.5;
16 } 16 }
17 17
18 var tests = [ 18 var tests = [
19
20 (Isolate isolate) async { 19 (Isolate isolate) async {
21 Map metrics = await isolate.refreshDartMetrics(); 20 Map metrics = await isolate.refreshDartMetrics();
22 expect(metrics.length, equals(1)); 21 expect(metrics.length, equals(1));
23 var counter = metrics['metrics/a.b.c']; 22 var counter = metrics['metrics/a.b.c'];
24 expect(counter.name, equals('a.b.c')); 23 expect(counter.name, equals('a.b.c'));
25 expect(counter.value, equals(1234.5)); 24 expect(counter.value, equals(1234.5));
26 }, 25 },
27
28 (Isolate isolate) async { 26 (Isolate isolate) async {
29 var params = { 'metricId': 'metrics/a.b.c' }; 27 var params = {'metricId': 'metrics/a.b.c'};
30 ServiceMetric counter = 28 ServiceMetric counter =
31 await isolate.invokeRpc('_getIsolateMetric', params); 29 await isolate.invokeRpc('_getIsolateMetric', params);
32 expect(counter.name, equals('a.b.c')); 30 expect(counter.name, equals('a.b.c'));
33 expect(counter.value, equals(1234.5)); 31 expect(counter.value, equals(1234.5));
34 }, 32 },
35
36 (Isolate isolate) async { 33 (Isolate isolate) async {
37 bool caughtException; 34 bool caughtException;
38 try { 35 try {
39 await isolate.invokeRpc('_getIsolateMetric', 36 await isolate
40 { 'metricId': 'metrics/a.b.d' }); 37 .invokeRpc('_getIsolateMetric', {'metricId': 'metrics/a.b.d'});
41 expect(false, isTrue, reason:'Unreachable'); 38 expect(false, isTrue, reason: 'Unreachable');
42 } on ServerRpcException catch (e) { 39 } on ServerRpcException catch (e) {
43 caughtException = true; 40 caughtException = true;
44 expect(e.code, equals(ServerRpcException.kInvalidParams)); 41 expect(e.code, equals(ServerRpcException.kInvalidParams));
45 expect(e.message, 42 expect(e.message,
46 "_getIsolateMetric: invalid 'metricId' parameter: metrics/a.b.d"); 43 "_getIsolateMetric: invalid 'metricId' parameter: metrics/a.b.d");
47 } 44 }
48 expect(caughtException, isTrue); 45 expect(caughtException, isTrue);
49 }, 46 },
50 ]; 47 ];
51 48
52 main(args) => runIsolateTests(args, tests, testeeBefore: script); 49 main(args) => runIsolateTests(args, tests, testeeBefore: script);
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/malformed_test.dart ('k') | runtime/observatory/tests/service/mirror_references_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698