runtime/observatory/tests/service/object_graph_stack_reference_test.dart - Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/object_graph_stack_reference_test.dart

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/next_through_function_expression_test.dart ('k') | runtime/observatory/tests/service/object_graph_user_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/object_graph_stack_reference_test.dart

diff --git a/runtime/observatory/tests/service/object_graph_stack_reference_test.dart b/runtime/observatory/tests/service/object_graph_stack_reference_test.dart

index 9fc88ce4958832afc16bfa2cf03b5cacef48e0e6..1f45eb2c19d1bce7af37a2fa3d75384348e44dfa 100644

--- a/runtime/observatory/tests/service/object_graph_stack_reference_test.dart

+++ b/runtime/observatory/tests/service/object_graph_stack_reference_test.dart

@@ -20,7 +20,7 @@ int minArraySize = arrayLength * 4;

void script() {

var stackSlot = new List(arrayLength);

debugger();

- print(stackSlot); // Prevent optimizing away the stack slot.

+ print(stackSlot); // Prevent optimizing away the stack slot.

}

checkForStackReferent(Isolate isolate) async {

@@ -38,8 +38,8 @@ checkForStackReferent(Isolate isolate) async {

ObjectGraph graph = snapshot.graph;

var root = graph.root;

- var stack = graph.root.dominatorTreeChildren()

- .singleWhere((child) => child.isStack);

+ var stack =

+ graph.root.dominatorTreeChildren().singleWhere((child) => child.isStack);

expect(stack.retainedSize, greaterThanOrEqualTo(minArraySize));

bool foundBigArray = false;