Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: runtime/observatory/tests/service/malformed_test.dart

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
7 import 'package:unittest/unittest.dart'; 7 import 'package:unittest/unittest.dart';
8 import 'test_helper.dart'; 8 import 'test_helper.dart';
9 9
10 var tests = [ 10 var tests = [
11 (Isolate isolate) async { 11 (Isolate isolate) async {
12 bool caughtException; 12 bool caughtException;
13 try { 13 try {
14 await isolate.invokeRpc('_respondWithMalformedObject', {}); 14 await isolate.invokeRpc('_respondWithMalformedObject', {});
15 expect(false, isTrue, reason:'Unreachable'); 15 expect(false, isTrue, reason: 'Unreachable');
16 } on MalformedResponseRpcException catch (e) { 16 } on MalformedResponseRpcException catch (e) {
17 caughtException = true; 17 caughtException = true;
18 expect(e.message, equals("Response is missing the 'type' field")); 18 expect(e.message, equals("Response is missing the 'type' field"));
19 } 19 }
20 expect(caughtException, isTrue); 20 expect(caughtException, isTrue);
21 }, 21 },
22 22
23 // Do this test last... it kills the vm connection. 23 // Do this test last... it kills the vm connection.
24 (Isolate isolate) async { 24 (Isolate isolate) async {
25 bool caughtException; 25 bool caughtException;
26 try { 26 try {
27 await isolate.invokeRpc('_respondWithMalformedJson', {}); 27 await isolate.invokeRpc('_respondWithMalformedJson', {});
28 expect(false, isTrue, reason:'Unreachable'); 28 expect(false, isTrue, reason: 'Unreachable');
29 } on NetworkRpcException catch (e) { 29 } on NetworkRpcException catch (e) {
30 caughtException = true; 30 caughtException = true;
31 expect(e.message, 31 expect(
32 startsWith("Canceling request: " 32 e.message,
33 "Connection saw corrupt JSON message: " 33 startsWith("Canceling request: "
34 "FormatException: Unexpected character")); 34 "Connection saw corrupt JSON message: "
35 "FormatException: Unexpected character"));
35 } 36 }
36 expect(caughtException, isTrue); 37 expect(caughtException, isTrue);
37 }, 38 },
38 ]; 39 ];
39 40
40 main(args) => runIsolateTests(args, tests); 41 main(args) => runIsolateTests(args, tests);
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/logging_test.dart ('k') | runtime/observatory/tests/service/metrics_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698