Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart b/runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
index 06f3d657d3d2ecd27c2da2fbe91a41039a50b79d..f7783ba706e48dd8035332030d2a442654e8de4c 100644
--- a/runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.dart
@@ -27,26 +27,41 @@ main() {
final paths = new RetainingPathRepositoryMock();
final instances = new InstanceRepositoryMock();
test('instantiation', () {
- final e = new MegamorphicCacheViewElement(vm, isolate, cache, events,
- notifs, caches, retainedSizes,
- reachableSizes, inbounds, paths,
- instances);
+ final e = new MegamorphicCacheViewElement(
+ vm,
+ isolate,
+ cache,
+ events,
+ notifs,
+ caches,
+ retainedSizes,
+ reachableSizes,
+ inbounds,
+ paths,
+ instances);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.isolate, equals(isolate));
expect(e.cache, equals(cache));
});
test('elements created after attachment', () async {
final caches = new MegamorphicCacheRepositoryMock(
- getter: expectAsync((i, id) async {
- expect(i, equals(isolate));
- expect(id, equals(cache.id));
- return cache;
- }, count: 1)
- );
- final e = new MegamorphicCacheViewElement(vm, isolate, cache, events,
- notifs, caches, retainedSizes,
- reachableSizes, inbounds, paths,
- instances);
+ getter: expectAsync((i, id) async {
+ expect(i, equals(isolate));
+ expect(id, equals(cache.id));
+ return cache;
+ }, count: 1));
+ final e = new MegamorphicCacheViewElement(
+ vm,
+ isolate,
+ cache,
+ events,
+ notifs,
+ caches,
+ retainedSizes,
+ reachableSizes,
+ inbounds,
+ paths,
+ instances);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');

Powered by Google App Engine
This is Rietveld 408576698