Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2458)

Unified Diff: runtime/observatory/tests/service/pause_idle_isolate_test.dart

Issue 2759973004: Fix observatory tests broken by running dartfmt. Temporarily reverted formatting for evaluate_activ… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/pause_idle_isolate_test.dart
diff --git a/runtime/observatory/tests/service/pause_idle_isolate_test.dart b/runtime/observatory/tests/service/pause_idle_isolate_test.dart
index d042f4b8558fa08b38e9bb41e4746bf97d4fb8f7..61de8d7d2162da9477d8eab03725c0234a26aae6 100644
--- a/runtime/observatory/tests/service/pause_idle_isolate_test.dart
+++ b/runtime/observatory/tests/service/pause_idle_isolate_test.dart
@@ -20,38 +20,34 @@ void testMain() {
}
var tests = [
-
-hasStoppedAtBreakpoint,
-
-(Isolate isolate) async {
- print('Resuming...');
- await isolate.resume();
-
- // Wait for the isolate to become idle. We detect this by querying
- // the stack until it becomes empty.
- var frameCount;
- do {
- var stack = await isolate.getStack();
- frameCount = stack['frames'].length;
- print('Frames: $frameCount');
- sleep(const Duration(milliseconds:10));
- } while (frameCount > 0);
- print('Isolate is idle.');
- await isolate.reload();
- expect(isolate.pauseEvent is M.ResumeEvent, isTrue);
-
- // Make sure that the isolate receives an interrupt even when it is
- // idle. (https://github.com/dart-lang/sdk/issues/24349)
- var interruptFuture = hasPausedFor(isolate, ServiceEvent.kPauseInterrupted);
- print('Pausing...');
- await isolate.pause();
- await interruptFuture;
-},
-
+ hasStoppedAtBreakpoint,
+ (Isolate isolate) async {
+ print('Resuming...');
+ await isolate.resume();
+
+ // Wait for the isolate to become idle. We detect this by querying
+ // the stack until it becomes empty.
+ var frameCount;
+ do {
+ var stack = await isolate.getStack();
+ frameCount = stack['frames'].length;
+ print('Frames: $frameCount');
+ sleep(const Duration(milliseconds: 10));
+ } while (frameCount > 0);
+ print('Isolate is idle.');
+ await isolate.reload();
+ expect(isolate.pauseEvent is M.ResumeEvent, isTrue);
+
+ // Make sure that the isolate receives an interrupt even when it is
+ // idle. (https://github.com/dart-lang/sdk/issues/24349)
+ var interruptFuture = hasPausedFor(isolate, ServiceEvent.kPauseInterrupted);
+ print('Pausing...');
+ await isolate.pause();
+ await interruptFuture;
+ },
];
main(args) => runIsolateTests(args, tests,
- testeeConcurrent: testMain,
- verbose_vm: true,
- extraArgs: [ '--trace-service',
- '--trace-service-verbose' ]);
+ testeeConcurrent: testMain,
+ verbose_vm: true,
+ extraArgs: ['--trace-service', '--trace-service-verbose']);

Powered by Google App Engine
This is Rietveld 408576698