Stop showing snackbar with success message when sharing with Chrome iOS.

Stop showing snackbar with success message when sharing with Chrome iOS.

BUG=699587
Review-Url: https://codereview.chromium.org/2752643004
Cr-Commit-Position: refs/heads/master@{#457438}
Committed: https://chromium.googlesource.com/chromium/src/+/e5fcd337dd2828a5eb9e911bbc2701f720a9cc40

[jif, 2017-03-14 18:30:02]

Description was changed from

==========
Stop showing snackbar with success message when sharing with Chrome iOS.

BUG=699587
==========

to

==========
Stop showing snackbar with success message when sharing with Chrome iOS.

BUG=699587
==========

[jif, 2017-03-14 18:30:02]

jif@chromium.org changed reviewers:
+ pkl@chromium.org

[jif, 2017-03-14 18:30:16]

ptal

[pkl (ping after 24h if needed), 2017-03-14 21:13:34]

LGTM with comment suggestions

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
File ios/chrome/browser/ui/activity_services/activity_type_util.h (right):

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
ios/chrome/browser/ui/activity_services/activity_type_util.h:61: // Returns the
message to present when the activity |type| successfully
s/successfully completed/has completed/

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
File ios/chrome/browser/ui/activity_services/activity_type_util.mm (right):

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
ios/chrome/browser/ui/activity_services/activity_type_util.mm:110: // was
successful.
Suggestion on improving the readability of this:
"For some activities, they can be reported as completed even if not
successfully.
Make sure that the message is meaningful even if the activity completed
unsuccessfully."

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
File ios/chrome/browser/ui/activity_services/share_protocol.h (right):

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
ios/chrome/browser/ui/activity_services/share_protocol.h:36: // message to be
displayed on successful completion. If |completionMessage| is
s/successful completion/completion/

[jif, 2017-03-15 10:41:17]

jif@chromium.org changed reviewers:
+ marq@chromium.org

[jif, 2017-03-15 10:41:18]

+marq for ios/c/b/ui/ OWNER check

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
File ios/chrome/browser/ui/activity_services/activity_type_util.h (right):

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
ios/chrome/browser/ui/activity_services/activity_type_util.h:61: // Returns the
message to present when the activity |type| successfully
On 2017/03/14 21:13:34, pklpkl wrote:
> s/successfully completed/has completed/

Done.

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
File ios/chrome/browser/ui/activity_services/activity_type_util.mm (right):

https://codereview.chromium.org/2752643004/diff/1/ios/chrome/browser/ui/activ...
ios/chrome/browser/ui/activity_services/activity_type_util.mm:110: // was
successful.
On 2017/03/14 21:13:34, pklpkl wrote:
> Suggestion on improving the readability of this:
> "For some activities, they can be reported as completed even if not
> successfully.
> Make sure that the message is meaningful even if the activity completed
> unsuccessfully."

This is much much better indeed.
Good thing I'm going to "Tech Writing 101" on friday!

Note that I changed the first sentence to:
// Some activities can be reported as completed even if not successful.

[marq (ping after 24h), 2017-03-16 13:45:32]

ui/ LGTM

[jif, 2017-03-16 14:45:01]

The CQ bit was checked by jif@chromium.org

[jif, 2017-03-16 14:45:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pkl@chromium.org
Link to the patchset: https://codereview.chromium.org/2752643004/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-03-16 14:45:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:15:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489675501389120,
"parent_rev": "8ef33b2cfea95309080e9d7f452233e0e780d5d8", "commit_rev":
"e5fcd337dd2828a5eb9e911bbc2701f720a9cc40"}

[commit-bot: I haz the power, 2017-03-16 15:15:47]

Description was changed from

==========
Stop showing snackbar with success message when sharing with Chrome iOS.

BUG=699587
==========

to

==========
Stop showing snackbar with success message when sharing with Chrome iOS.

BUG=699587

Review-Url: https://codereview.chromium.org/2752643004
Cr-Commit-Position: refs/heads/master@{#457438}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5fcd337dd2828a5eb9e911bbc27...
==========

[commit-bot: I haz the power, 2017-03-16 15:15:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5fcd337dd2828a5eb9e911bbc27...