Stop showing snackbar with success message when sharing with Chrome iOS.

ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/activity_services/activity_service_controller.h"
 
 #import <MobileCoreServices/MobileCoreServices.h>
 
 #import "base/test/ios/wait_util.h"
 #include "components/reading_list/core/reading_list_switches.h"
@@ skipping 146 matching lines @@
       blockCalled = true;
     };
     // OCMock does not allow "any" specification for non-object parameters.
     // To implement something that accept any non-SHARE_SUCCESS parameter
     // to calling this method, all the non-success values have to be
     // enumerated.
     [[[shareToDelegateMock stub] andDo:validationBlock]
         passwordAppExDidFinish:ShareTo::ShareResult::SHARE_CANCEL
                       username:OCMOCK_ANY
                       password:OCMOCK_ANY
-                successMessage:OCMOCK_ANY];
+             completionMessage:OCMOCK_ANY];
     [[[shareToDelegateMock stub] andDo:validationBlock]
         passwordAppExDidFinish:ShareTo::ShareResult::SHARE_NETWORK_FAILURE
                       username:OCMOCK_ANY
                       password:OCMOCK_ANY
-                successMessage:OCMOCK_ANY];
+             completionMessage:OCMOCK_ANY];
     [[[shareToDelegateMock stub] andDo:validationBlock]
         passwordAppExDidFinish:ShareTo::ShareResult::SHARE_SIGN_IN_FAILURE
                       username:OCMOCK_ANY
                       password:OCMOCK_ANY
-                successMessage:OCMOCK_ANY];
+             completionMessage:OCMOCK_ANY];
     [[[shareToDelegateMock stub] andDo:validationBlock]
         passwordAppExDidFinish:ShareTo::ShareResult::SHARE_ERROR
                       username:OCMOCK_ANY
                       password:OCMOCK_ANY
-                successMessage:OCMOCK_ANY];
+             completionMessage:OCMOCK_ANY];
     [[[shareToDelegateMock stub] andDo:validationBlock]
         passwordAppExDidFinish:ShareTo::ShareResult::SHARE_UNKNOWN_RESULT
                       username:OCMOCK_ANY
                       password:OCMOCK_ANY
-                successMessage:OCMOCK_ANY];
+             completionMessage:OCMOCK_ANY];
     [activityController setShareToDelegateForTesting:(id)shareToDelegateMock];
 
     // Sets up the returned item from a Password Management App Extension.
     NSString* activityType = activity_services::kAppExtensionLastPass;
     ShareTo::ShareResult result = ShareTo::ShareResult::SHARE_SUCCESS;
     BOOL resetUI =
         [activityController processItemsReturnedFromActivity:activityType
                                                       status:result
                                                        items:extensionItems];
     ASSERT_EQ(expectedResetUI, resetUI);
     base::test::ios::WaitUntilCondition(^{
       return blockCalled;
     });
     EXPECT_OCMOCK_VERIFY(shareToDelegateMock);
   }
 
   web::TestWebThreadBundle thread_bundle_;
   UIViewController* parentController_;
   OCMockObject* shareToDelegate_;
   ShareToData* shareData_;
 };
 
 TEST_F(ActivityServiceControllerTest, PresentAndDismissController) {
   [[shareToDelegate_ expect] shareDidComplete:ShareTo::ShareResult::SHARE_CANCEL
-                               successMessage:[OCMArg isNil]];
+                            completionMessage:[OCMArg isNil]];
 
   UIViewController* parentController =
       static_cast<UIViewController*>(parentController_);
   ActivityServiceController* activityController =
       [[ActivityServiceController alloc] init];
   EXPECT_FALSE([activityController isActive]);
 
   // Test sharing.
   [activityController shareWithData:shareData_
                          controller:parentController
@@ skipping 121 matching lines @@
   EXPECT_NSEQ(@"https://chromium.org/login.html", [item absoluteString]);
 }
 
 // Verifies that -processItemsReturnedFromActivity:status:item: contains
 // the username and password.
 TEST_F(ActivityServiceControllerTest, ProcessItemsReturnedSuccessfully) {
   ActivityServiceController* activityController =
       [[ActivityServiceController alloc] init];
 
   // Sets up a Mock ShareToDelegate object to check that the callback function
-  // -passwordAppExDidFinish:username:password:successMessage:
+  // -passwordAppExDidFinish:username:password:completionMessage:
   // is correct with the correct username and password.
   OCMockObject* shareToDelegateMock =
       [OCMockObject mockForProtocol:@protocol(ShareToDelegate)];
   NSString* const kSecretUsername = @"john.doe";
   NSString* const kSecretPassword = @"super!secret";
   __block bool blockCalled = false;
   void (^validationBlock)(NSInvocation*) = ^(NSInvocation* invocation) {
     __unsafe_unretained NSString* username;
     __unsafe_unretained NSString* password;
     // Skips 0 and 1 index because they are |self| and |cmd|.
     [invocation getArgument:&username atIndex:3];
     [invocation getArgument:&password atIndex:4];
     EXPECT_NSEQ(kSecretUsername, username);
     EXPECT_NSEQ(kSecretPassword, password);
     blockCalled = true;
   };
   [[[shareToDelegateMock stub] andDo:validationBlock]
       passwordAppExDidFinish:ShareTo::ShareResult::SHARE_SUCCESS
                     username:OCMOCK_ANY
                     password:OCMOCK_ANY
-              successMessage:OCMOCK_ANY];
+           completionMessage:OCMOCK_ANY];
   [activityController setShareToDelegateForTesting:(id)shareToDelegateMock];
 
   // Sets up the returned item from a Password Management App Extension.
   NSString* activityType = @"com.software.find-login-action.extension";
   ShareTo::ShareResult result = ShareTo::ShareResult::SHARE_SUCCESS;
   NSDictionary* dictionaryFromAppEx =
       @{ @"username" : kSecretUsername,
          @"password" : kSecretPassword };
   NSItemProvider* itemProvider =
       [[NSItemProvider alloc] initWithItem:dictionaryFromAppEx
                             typeIdentifier:(NSString*)kUTTypePropertyList];
   NSExtensionItem* extensionItem = [[NSExtensionItem alloc] init];
   [extensionItem setAttachments:@[ itemProvider ]];
 
   BOOL resetUI =
       [activityController processItemsReturnedFromActivity:activityType
                                                     status:result
                                                      items:@[ extensionItem ]];
   ASSERT_FALSE(resetUI);
-  // Wait for -passwordAppExDidFinish:username:password:successMessage:
+  // Wait for -passwordAppExDidFinish:username:password:completionMessage:
   // to be called.
   base::test::ios::WaitUntilCondition(^{
     return blockCalled;
   });
   EXPECT_OCMOCK_VERIFY(shareToDelegateMock);
 }
 
 // Verifies that -processItemsReturnedFromActivity:status:item: fails when
 // called with invalid NSExtensionItem.
 TEST_F(ActivityServiceControllerTest, ProcessItemsReturnedFailures) {
@@ skipping 75 matching lines @@
   // public.url UTType in order to allow Share actions (e.g. Facebook, Twitter,
   // etc) to appear on UIActivityViewController opened by Chrome).
   CFStringRef chromeFindLoginAction = reinterpret_cast<CFStringRef>(
       activity_services::kUTTypeAppExtensionFindLoginAction);
   EXPECT_TRUE(UTTypeConformsTo(chromeFindLoginAction, kUTTypeURL));
   EXPECT_TRUE(
       UTTypeConformsTo(chromeFindLoginAction, onePasswordFindLoginAction));
 }
 
 }  // namespace